extensions/renderer/resources/extensions_renderer_resources.grd - Issue 537773003: Add a user agent stylesheet for extension options pages

Unified Diff: extensions/renderer/resources/extensions_renderer_resources.grd

Issue 537773003: Add a user agent stylesheet for extension options pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Data URI hardcoding, remove deprecated WebKit CSS declarations Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/extensions_renderer_resources.grd

diff --git a/extensions/renderer/resources/extensions_renderer_resources.grd b/extensions/renderer/resources/extensions_renderer_resources.grd

index ca31fbac02a3277e7accbc335265b319df437a71..e2417c586013ed129d57a285c790b25343a28713 100644

--- a/extensions/renderer/resources/extensions_renderer_resources.grd

+++ b/extensions/renderer/resources/extensions_renderer_resources.grd

@@ -54,6 +54,7 @@

+ <include name="IDR_EXTENSION_FONTS_CSS" file="extension_fonts.css" type="BINDATA"/>

Marijn Kruisselbrink 2014/09/10 20:46:30 I'm not entirely sure, but will this work to get t

ericzeng 2014/09/10 21:29:30 Which <if expr> are you referring to? I am not fam

Marijn Kruisselbrink 2014/09/10 21:45:40 If you look at widgets.css (or at the extension.cs

ericzeng 2014/09/10 22:13:48 If I change the type from BINDATA it looks like gr

If I change the type from BINDATA it looks like grit is taking care of the <if expr> for me. However, I'm certain that I won't be allowed to use the relative urls for background-image. I've done a little testing and it looks like grit doesn't touch the parameters to url(...), at least in extension_renderer_resources.

Marijn Kruisselbrink 2014/09/10 22:32:04 I just tested this, if I add the following to exte

On 2014/09/10 22:13:48, ericzeng wrote: > On 2014/09/10 21:45:40, Marijn Kruisselbrink wrote: > > On 2014/09/10 21:29:30, ericzeng wrote: > > > On 2014/09/10 20:46:30, Marijn Kruisselbrink wrote: > > > > I'm not entirely sure, but will this work to get the <if expr> bits to be > > > > evaluated by grit? The original widgets.css etc files are included as > > > > <structure name="IDR_WEBUI_CSS_WIDGETS" > > > > file="css/widgets.css" type="chrome_html" > > > > flattenhtml="true" /> > > > > instead of the <include> you use here (I have no idea what the flattenhtml > > > > attribute there does though, it only seems to be present for widgets.css, > > not > > > > for most of the other webui css files). > > > > > > Which <if expr> are you referring to? I am not familiar with how grit works. > > It > > > seems that the other CSS files in extensions work just fine as an <include>. > > If you look at widgets.css (or at the extension.css file you added) you see > > various lines like <if expr="is_win">, these lines are not valid css. What > > happens (if I understand how it works) is that (if you properly tell grit to > > process these files as "chrome_html" files) grit will parse these tags and > only > > include the bits that are correct for the current platform. > > > > But having said that, there seems to be more magic that grit does, which might > > help or hurt you. One thing it seems to do is replace relative file urls with > > data urls (just look at widgets.css as it is injected into webui pages, it has > > data urls instead of relative urls). So maybe just running your css through > grit > > (with the proper relative paths to the png files) will do all the hard work > for > > you at compile time. (but again, I'm not entirely sure how grit works, so it > > might be more complicated then that... > > If I change the type from BINDATA it looks like grit is taking care of the <if > expr> for me. > > However, I'm certain that I won't be allowed to use the relative urls for > background-image. I've done a little testing and it looks like grit doesn't > touch the parameters to url(...), at least in extension_renderer_resources.

I just tested this, if I add the following to extensions_renderer_resources.grd: <structures> <structure name="IDR_EXTENSION_CSS" file="extension.css" type="chrome_html" flattenhtml="true" /> </structures> (as well as add "structures": [26890] to the extensions_renderer_resources.grd entry in tools/gritsettings/resource_ids) And then change the resource urls in extension.css to be things like url(../../../ui/webui/resources/images/select.png) grit correctly replaces all these urls with data urls.

ericzeng 2014/09/10 22:52:53 Wow, I didn't know that was possible. Thanks!

On 2014/09/10 22:32:04, Marijn Kruisselbrink wrote: > On 2014/09/10 22:13:48, ericzeng wrote: > > On 2014/09/10 21:45:40, Marijn Kruisselbrink wrote: > > > On 2014/09/10 21:29:30, ericzeng wrote: > > > > On 2014/09/10 20:46:30, Marijn Kruisselbrink wrote: > > > > > I'm not entirely sure, but will this work to get the <if expr> bits to > be > > > > > evaluated by grit? The original widgets.css etc files are included as > > > > > <structure name="IDR_WEBUI_CSS_WIDGETS" > > > > > file="css/widgets.css" type="chrome_html" > > > > > flattenhtml="true" /> > > > > > instead of the <include> you use here (I have no idea what the > flattenhtml > > > > > attribute there does though, it only seems to be present for > widgets.css, > > > not > > > > > for most of the other webui css files). > > > > > > > > Which <if expr> are you referring to? I am not familiar with how grit > works. > > > It > > > > seems that the other CSS files in extensions work just fine as an > <include>. > > > If you look at widgets.css (or at the extension.css file you added) you see > > > various lines like <if expr="is_win">, these lines are not valid css. What > > > happens (if I understand how it works) is that (if you properly tell grit to > > > process these files as "chrome_html" files) grit will parse these tags and > > only > > > include the bits that are correct for the current platform. > > > > > > But having said that, there seems to be more magic that grit does, which > might > > > help or hurt you. One thing it seems to do is replace relative file urls > with > > > data urls (just look at widgets.css as it is injected into webui pages, it > has > > > data urls instead of relative urls). So maybe just running your css through > > grit > > > (with the proper relative paths to the png files) will do all the hard work > > for > > > you at compile time. (but again, I'm not entirely sure how grit works, so it > > > might be more complicated then that... > > > > If I change the type from BINDATA it looks like grit is taking care of the <if > > expr> for me. > > > > However, I'm certain that I won't be allowed to use the relative urls for > > background-image. I've done a little testing and it looks like grit doesn't > > touch the parameters to url(...), at least in extension_renderer_resources. > > I just tested this, if I add the following to extensions_renderer_resources.grd: > <structures> > <structure name="IDR_EXTENSION_CSS" > file="extension.css" type="chrome_html" > flattenhtml="true" /> > > </structures> > > (as well as add "structures": [26890] to the > extensions_renderer_resources.grd entry in tools/gritsettings/resource_ids) > > And then change the resource urls in extension.css to be things like > url(../../../ui/webui/resources/images/select.png) grit correctly replaces all > these urls with data urls.

Wow, I didn't know that was possible. Thanks!

</includes>

</release>

</grit>

« extensions/renderer/resources/extension.css ('K') | « extensions/renderer/resources/extension_fonts.css ('k') | no next file » | no next file with comments »