Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: content/common/input/gesture_event_stream_validator_unittest.cc

Issue 537733003: [Android] Enable input event stream validation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review and fix tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/input/gesture_event_stream_validator_unittest.cc
diff --git a/content/common/input/gesture_event_stream_validator_unittest.cc b/content/common/input/gesture_event_stream_validator_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2a97d8bfabb86828a3481e0061eddf69af2ac116
--- /dev/null
+++ b/content/common/input/gesture_event_stream_validator_unittest.cc
@@ -0,0 +1,214 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/input/gesture_event_stream_validator.h"
+
+#include "content/common/input/synthetic_web_input_event_builders.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using blink::WebInputEvent;
+using blink::WebGestureEvent;
+
+namespace content {
+namespace {
+
+const blink::WebGestureDevice kDefaultGestureDevice =
+ blink::WebGestureDeviceTouchscreen;
+
+blink::WebGestureEvent Build(WebInputEvent::Type type) {
+ return SyntheticWebGestureEventBuilder::Build(type, kDefaultGestureDevice);
+}
+
+} // namespace
+
+TEST(GestureEventStreamValidator, ValidScroll) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ event = Build(WebInputEvent::GestureScrollBegin);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureScrollUpdate);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureScrollEnd);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidScroll) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ // No preceding ScrollBegin.
+ event = Build(WebInputEvent::GestureScrollUpdate);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ // No preceding ScrollBegin.
+ event = Build(WebInputEvent::GestureScrollEnd);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureScrollBegin);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ // Already scrolling.
+ event = Build(WebInputEvent::GestureScrollBegin);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureScrollEnd);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ // Scroll already ended.
+ event = Build(WebInputEvent::GestureScrollEnd);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, ValidFling) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ event = Build(WebInputEvent::GestureScrollBegin);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureFlingStart);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidFling) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ // No preceding ScrollBegin.
+ event = Build(WebInputEvent::GestureFlingStart);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, ValidPinch) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ event = Build(WebInputEvent::GesturePinchBegin);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GesturePinchUpdate);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GesturePinchEnd);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidPinch) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ // No preceding PinchBegin.
+ event = Build(WebInputEvent::GesturePinchUpdate);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ event = Build(WebInputEvent::GesturePinchBegin);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ // ScrollBegin while pinching.
+ event = Build(WebInputEvent::GestureScrollBegin);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ // ScrollEnd while pinching.
+ event = Build(WebInputEvent::GestureScrollEnd);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ // Pinch already begun.
+ event = Build(WebInputEvent::GesturePinchBegin);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ event = Build(WebInputEvent::GesturePinchEnd);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ // Pinch already ended.
+ event = Build(WebInputEvent::GesturePinchEnd);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, ValidTap) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ event = Build(WebInputEvent::GestureTapDown);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureTap);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureTapDown);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureTapCancel);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ // DoubleTap doesn't require a TapDown (unlike Tap and TapCancel).
+ event = Build(WebInputEvent::GestureDoubleTap);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidTap) {
+ GestureEventStreamValidator validator;
+ std::string error_msg;
+ WebGestureEvent event;
+
+ // No preceding TapDown.
+ event = Build(WebInputEvent::GestureTap);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureTapCancel);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+
+ // TapDown already terminated.
+ event = Build(WebInputEvent::GestureTapDown);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureDoubleTap);
+ EXPECT_TRUE(validator.Validate(event, &error_msg));
+ EXPECT_TRUE(error_msg.empty());
+
+ event = Build(WebInputEvent::GestureTapCancel);
+ EXPECT_FALSE(validator.Validate(event, &error_msg));
+ EXPECT_FALSE(error_msg.empty());
+}
+
+} // namespace content
« no previous file with comments | « content/common/input/gesture_event_stream_validator.cc ('k') | content/common/input/touch_event_stream_validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698