[Android] Enable input event stream validation

content/common/input/gesture_event_stream_validator_unittest.cc

Index: content/common/input/gesture_event_stream_validator_unittest.cc
diff --git a/content/common/input/gesture_event_stream_validator_unittest.cc b/content/common/input/gesture_event_stream_validator_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..672fb9351380ae697f00012e2f389c4a26cf4f76
--- /dev/null
+++ b/content/common/input/gesture_event_stream_validator_unittest.cc
@@ -0,0 +1,222 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/input/gesture_event_stream_validator.h"
+
+#include "content/common/input/synthetic_web_input_event_builders.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using blink::WebInputEvent;
+using blink::WebGestureEvent;
+
+namespace content {
+namespace {
+
+const blink::WebGestureDevice kDefaultGestureDevice =
+    blink::WebGestureDeviceTouchscreen;
+
+blink::WebGestureEvent Build(WebInputEvent::Type type) {
+  return SyntheticWebGestureEventBuilder::Build(type, kDefaultGestureDevice);
+}
+
+}  // namespace
+
+TEST(GestureEventStreamValidator, ValidScroll) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureScrollUpdate);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureScrollEnd);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidScroll) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  // No preceding ScrollBegin.
+  event = Build(WebInputEvent::GestureScrollUpdate);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  // No preceding ScrollBegin.
+  event = Build(WebInputEvent::GestureScrollEnd);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  // Already scrolling.
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureScrollEnd);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  // Scroll already ended.
+  event = Build(WebInputEvent::GestureScrollEnd);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, ValidFling) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureFlingStart);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidFling) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  // No preceding ScrollBegin.
+  event = Build(WebInputEvent::GestureFlingStart);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, ValidPinch) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GesturePinchBegin);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GesturePinchUpdate);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GesturePinchEnd);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureScrollEnd);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidPinch) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  // No preceding ScrollBegin.
+  event = Build(WebInputEvent::GesturePinchBegin);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  event = Build(WebInputEvent::GesturePinchEnd);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));

[tdresser, 2014/09/04 21:25:00]

This is one of very few places where you don't check the contents of the
|error_msg|. Might as well make things consistent.

[jdduke (slow), 2014/09/04 22:48:56]

Done.

+
+  // No preceding PinchBegin.
+  event = Build(WebInputEvent::GesturePinchUpdate);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  // Already scrolling.
+  event = Build(WebInputEvent::GestureScrollBegin);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));

[tdresser, 2014/09/04 21:25:00]

ditto

[jdduke (slow), 2014/09/04 22:48:56]

Done.

+
+  // No preceding PinchBegin.
+  event = Build(WebInputEvent::GesturePinchEnd);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, ValidTap) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  event = Build(WebInputEvent::GestureTapDown);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureTap);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureTapDown);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureTapCancel);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureTapDown);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureDoubleTap);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+}
+
+TEST(GestureEventStreamValidator, InvalidTap) {
+  GestureEventStreamValidator validator;
+  std::string error_msg;
+  WebGestureEvent event;
+
+  // No preceding TapDown.
+  event = Build(WebInputEvent::GestureTap);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureTapCancel);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureDoubleTap);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+
+  // TapDown already terminated.
+  event = Build(WebInputEvent::GestureTapDown);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureDoubleTap);
+  EXPECT_TRUE(validator.Validate(event, &error_msg));
+  EXPECT_TRUE(error_msg.empty());
+
+  event = Build(WebInputEvent::GestureDoubleTap);
+  EXPECT_FALSE(validator.Validate(event, &error_msg));
+  EXPECT_FALSE(error_msg.empty());
+}
+
+}  // namespace content