Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 537713002: Revert to enabling all of -O2 as it exposes a bug in the toolchain. (Closed)

Created:
6 years, 3 months ago by djsollen
Modified:
6 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert to enabling all of -O2 as it exposes a bug in the toolchain. Instead as a workaround we will temporarily disable tiling the few GMs that produce errors with the existing 64-bit ARM toolchain. BUG=skia:2908 Committed: https://skia.googlesource.com/skia/+/6233c7b2d3f0b5dcc331e88d8029523bdf08217a

Patch Set 1 #

Total comments: 1

Patch Set 2 : shorter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M gm/bitmaprect.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
djsollen
6 years, 3 months ago (2014-09-03 20:20:35 UTC) #2
mtklein
lgtm https://codereview.chromium.org/537713002/diff/1/gm/bitmaprect.cpp File gm/bitmaprect.cpp (right): https://codereview.chromium.org/537713002/diff/1/gm/bitmaprect.cpp#newcode51 gm/bitmaprect.cpp:51: return this->INHERITED::onGetFlags() | GM::kSkipTiled_Flag; Seems fine, but all ...
6 years, 3 months ago (2014-09-03 20:24:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/537713002/20001
6 years, 3 months ago (2014-09-03 20:30:56 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 20:38:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 6233c7b2d3f0b5dcc331e88d8029523bdf08217a

Powered by Google App Engine
This is Rietveld 408576698