Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 537703003: Keep a copy of page id in RenderViewHost. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Keep a copy of page id in RenderViewHost. This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them. BUG=407376 TEST=this may crash for a few people Committed: https://crrev.com/45db74f875d668805afad8e73b7840e9df9c3215 Cr-Commit-Position: refs/heads/master@{#293229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -11 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 5 chunks +32 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
You've seen this before. Again, I'm doing a temporary commit to gather more data as ...
6 years, 3 months ago (2014-09-03 20:25:12 UTC) #2
Robert Sesek
Stampystamp LGTM
6 years, 3 months ago (2014-09-03 20:26:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/537703003/1
6 years, 3 months ago (2014-09-03 20:30:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f325b403581a6827427e8b0861d944cb9db3f0cc
6 years, 3 months ago (2014-09-04 00:09:18 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45db74f875d668805afad8e73b7840e9df9c3215
Cr-Commit-Position: refs/heads/master@{#293229}

Powered by Google App Engine
This is Rietveld 408576698