Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: media/base/bit_reader_core.cc

Issue 537653002: Increase DVLOG level of BitReader::SkipBits() from 0 to 1 and add TODO. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/bit_reader_core.cc
diff --git a/media/base/bit_reader_core.cc b/media/base/bit_reader_core.cc
index 2f168ffd67c11a445cbf2a2a6c0930a9d56feeee..7087c331029179701711a0f830b08cde68775c08 100644
--- a/media/base/bit_reader_core.cc
+++ b/media/base/bit_reader_core.cc
@@ -52,8 +52,9 @@ int BitReaderCore::PeekBitsMsbAligned(int num_bits, uint64* out) {
}
bool BitReaderCore::SkipBits(int num_bits) {
+ // TODO(dalecurtis): Rewrite to be efficient, see http://crbug.com/376450
DCHECK_GE(num_bits, 0);
- DVLOG_IF(0, num_bits > 100)
+ DVLOG_IF(1, num_bits > 100)
<< "BitReader::SkipBits inefficient for large skips";
uint64 dummy;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698