Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 537653002: Increase DVLOG level of BitReader::SkipBits() from 0 to 1 and add TODO. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Increase DVLOG level of BitReader::SkipBits() from 0 to 1 and add TODO. DVLOG(0) is way too spammy for such a low-level function. BUG=376450 TBR=dalecurtis Committed: https://crrev.com/0bd44664493d6783c2d901e2c2c7a01d9a174998 Cr-Commit-Position: refs/heads/master@{#293192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/base/bit_reader_core.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
scherkus (not reviewing)
dalecurtis: I picked you because you did at least some level of investigation, but by ...
6 years, 3 months ago (2014-09-03 18:07:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/537653002/1
6 years, 3 months ago (2014-09-03 18:08:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-03 19:18:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a240f6633d4e3c3bac79768719378716ecbc06e1
6 years, 3 months ago (2014-09-03 20:33:56 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:27:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bd44664493d6783c2d901e2c2c7a01d9a174998
Cr-Commit-Position: refs/heads/master@{#293192}

Powered by Google App Engine
This is Rietveld 408576698