|
|
DescriptionAdd OWNERS for src/ui/ios.
BUG=None
NOTRY=true
Committed: https://crrev.com/208c2898ca5aae07f2728b6393ff22e2ae3a174c
Cr-Commit-Position: refs/heads/master@{#293563}
Patch Set 1 #Patch Set 2 : removed stuartmorgan; added rohitrao and sdefresne #
Total comments: 4
Patch Set 3 : fixed email domain #Messages
Total messages: 20 (5 generated)
lliabraa@chromium.org changed reviewers: + stuartmorgan@chromium.org, thakis@chromium.org
@stuartmorgan for iOS review; @thakis for ui/OWNERS
Rohit is probably a better choice than me. We should also see if there's someone in Europe who would be a good fit. Peter, thoughts?
On 2014/09/04 22:02:54, stuartmorgan wrote: > Rohit is probably a better choice than me. We should also see if there's someone > in Europe who would be a good fit. Peter, thoughts? I would nominate sdefresne.
lliabraa@chromium.org changed reviewers: + rohitrao@chromium.org, sdefresne@chromium.org - stuartmorgan@chromium.org
https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS File ui/ios/OWNERS (right): https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com Use @chromium.org addresses for everyone.
https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS File ui/ios/OWNERS (right): https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com %s/google/chromium/g
thanks for the reviews https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS File ui/ios/OWNERS (right): https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com On 2014/09/05 12:47:29, sdefresne wrote: > %s/google/chromium/g Done. https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com On 2014/09/05 12:46:48, rohitrao wrote: > Use @chromium.org addresses for everyone. Done.
lgtm
lgtm
lgtm
The CQ bit was checked by lliabraa@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/537633004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/537633004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as bd067be87fb8c87abb2d70a6709ccc28bccd8484
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/208c2898ca5aae07f2728b6393ff22e2ae3a174c Cr-Commit-Position: refs/heads/master@{#293563} |