Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 537633004: Add OWNERS for src/ui/ios. (Closed)

Created:
6 years, 3 months ago by lliabraa
Modified:
5 years, 2 months ago
CC:
chromium-reviews, pkl, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add OWNERS for src/ui/ios. BUG=None NOTRY=true Committed: https://crrev.com/208c2898ca5aae07f2728b6393ff22e2ae3a174c Cr-Commit-Position: refs/heads/master@{#293563}

Patch Set 1 #

Patch Set 2 : removed stuartmorgan; added rohitrao and sdefresne #

Total comments: 4

Patch Set 3 : fixed email domain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + ui/ios/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (5 generated)
lliabraa
@stuartmorgan for iOS review; @thakis for ui/OWNERS
6 years, 3 months ago (2014-09-04 19:08:02 UTC) #2
stuartmorgan
Rohit is probably a better choice than me. We should also see if there's someone ...
6 years, 3 months ago (2014-09-04 22:02:54 UTC) #3
pkl (ping after 24h if needed)
On 2014/09/04 22:02:54, stuartmorgan wrote: > Rohit is probably a better choice than me. We ...
6 years, 3 months ago (2014-09-05 11:38:26 UTC) #4
lliabraa
6 years, 3 months ago (2014-09-05 11:51:40 UTC) #6
rohitrao (ping after 24h)
https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS File ui/ios/OWNERS (right): https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com Use @chromium.org addresses for everyone.
6 years, 3 months ago (2014-09-05 12:46:48 UTC) #7
sdefresne
https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS File ui/ios/OWNERS (right): https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com %s/google/chromium/g
6 years, 3 months ago (2014-09-05 12:47:29 UTC) #8
lliabraa
thanks for the reviews https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS File ui/ios/OWNERS (right): https://codereview.chromium.org/537633004/diff/20001/ui/ios/OWNERS#newcode1 ui/ios/OWNERS:1: lliabraa@google.com On 2014/09/05 12:47:29, sdefresne ...
6 years, 3 months ago (2014-09-05 12:51:21 UTC) #9
rohitrao (ping after 24h)
lgtm
6 years, 3 months ago (2014-09-05 17:39:06 UTC) #10
sdefresne
lgtm
6 years, 3 months ago (2014-09-05 17:39:14 UTC) #11
Nico
lgtm
6 years, 3 months ago (2014-09-05 17:40:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/537633004/40001
6 years, 3 months ago (2014-09-05 17:48:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2517)
6 years, 3 months ago (2014-09-05 18:44:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/537633004/40001
6 years, 3 months ago (2014-09-05 18:50:11 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bd067be87fb8c87abb2d70a6709ccc28bccd8484
6 years, 3 months ago (2014-09-05 18:52:02 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:02 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/208c2898ca5aae07f2728b6393ff22e2ae3a174c
Cr-Commit-Position: refs/heads/master@{#293563}

Powered by Google App Engine
This is Rietveld 408576698