Implement SSLKEYLOGFILE for OpenSSL.

Implement SSLKEYLOGFILE for OpenSSL.

For feature parity with NSS.

BUG=393477
Committed: https://crrev.com/018aad6f6980144a2b93aacb24e98fb7b175a0f0
Cr-Commit-Position: refs/heads/master@{#294527}

[davidben, 2014-09-11 14:23:52]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2014-09-11 14:23:52]

Sending this out for review now that BoringSSL's been rolled.

[Ryan Sleevi, 2014-09-11 23:20:43]

lgtm

https://codereview.chromium.org/537633003/diff/1/net/socket/ssl_client_socket...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/537633003/diff/1/net/socket/ssl_client_socket...
net/socket/ssl_client_socket_openssl.cc:183: LOG(ERROR) << "Failed to open " <<
ssl_keylog_file;
Comparison: In NSS world, this is a noop.

[davidben, 2014-09-11 23:30:19]

https://codereview.chromium.org/537633003/diff/1/net/socket/ssl_client_socket...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/537633003/diff/1/net/socket/ssl_client_socket...
net/socket/ssl_client_socket_openssl.cc:183: LOG(ERROR) << "Failed to open " <<
ssl_keylog_file;
On 2014/09/11 23:20:43, Ryan Sleevi wrote:
> Comparison: In NSS world, this is a noop.

Well, NSS has an SSL_TRACE call, but yeah that's a no-op for normal builds. I
thought printing an error would probably be tidy; if you're running Chrome with
SSLKEYLOGFILE, one would hope you're doing so intentionally and care about the
error. (Otherwise we have worse problems...)

[davidben, 2014-09-12 00:00:50]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-09-12 00:15:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/537633003/1

[commit-bot: I haz the power, 2014-09-12 02:29:58]

Committed patchset #1 (id:1) as 84ab6e72bb5d653b476e795ab236399c547005bd

[commit-bot: I haz the power, 2014-09-12 02:42:36]

Patchset 1 (id:??) landed as
https://crrev.com/018aad6f6980144a2b93aacb24e98fb7b175a0f0
Cr-Commit-Position: refs/heads/master@{#294527}