Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 53763003: Initialize per-ChromeOS-user NSS slots and provide the functions to access them. (Closed)

Created:
7 years, 1 month ago by mattm
Modified:
7 years ago
Reviewers:
xiyuan, wtc, Ryan Sleevi, mmenke
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Initialize per-ChromeOS-user NSS slots and provide the functions to access them. BUG=302124 R=mmenke@chromium.org, rsleevi@chromium.org, xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239266

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : add CONTENT_EXPORTs #

Patch Set 4 : change dbus failure to NOTREACHED #

Patch Set 5 : logging cleanups #

Patch Set 6 : move the stuff out of content/ again #

Patch Set 7 : sync to r233709 #

Patch Set 8 : sync to r234388 #

Patch Set 9 : add thread checks #

Patch Set 10 : sync to r235279 #

Total comments: 20

Patch Set 11 : rebase to r237487 #

Patch Set 12 : review changes for comment #12 #

Patch Set 13 : linux build fix #

Total comments: 15

Patch Set 14 : rebase to 238776 #

Patch Set 15 : changes for comment #15 #

Total comments: 4

Patch Set 16 : changes for comment #19 #

Patch Set 17 : fix CertificateManagerBrowserTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -14 lines) Patch
A chrome/browser/net/nss_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/net/nss_context_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/net/nss_context_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +132 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +27 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -0 lines 0 comments Download
M crypto/nss_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +10 lines, -1 line 0 comments Download
M crypto/nss_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 14 chunks +227 lines, -9 lines 0 comments Download
M crypto/nss_util_internal.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +41 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
mattm
jam: content/ rsleevi: the rest
7 years, 1 month ago (2013-10-31 01:14:09 UTC) #1
jam
who's calling this code? if it's just chrome layer, the new files shouldn't be in ...
7 years, 1 month ago (2013-10-31 06:23:10 UTC) #2
mattm
On 2013/10/31 06:23:10, jam wrote: > who's calling this code? if it's just chrome layer, ...
7 years, 1 month ago (2013-10-31 06:51:06 UTC) #3
mattm
On 2013/10/31 06:51:06, mattm wrote: > On 2013/10/31 06:23:10, jam wrote: > > who's calling ...
7 years, 1 month ago (2013-10-31 22:46:43 UTC) #4
mattm
+joi Looks like jam is OOO. Joi, can you provide an opinion? Should this Chromeos ...
7 years, 1 month ago (2013-11-01 02:26:03 UTC) #5
Ryan Sleevi
On 2013/11/01 02:26:03, mattm wrote: > +joi > Looks like jam is OOO. Joi, can ...
7 years, 1 month ago (2013-11-01 02:28:20 UTC) #6
Jói
If keygen is part of HTML5, then as much of its implementation as reasonable (i.e. ...
7 years, 1 month ago (2013-11-01 09:20:50 UTC) #7
mattm
On 2013/11/01 09:20:50, Jói wrote: > If keygen is part of HTML5, then as much ...
7 years, 1 month ago (2013-11-01 15:19:06 UTC) #8
Jói
Great, sounds like extending the CryptoPasswordDelegate to do both things is the way to go ...
7 years, 1 month ago (2013-11-01 17:18:52 UTC) #9
mattm
Ok, I've updated the CL to keep the magic inside chrome/. I'll do the delegate ...
7 years, 1 month ago (2013-11-01 21:14:40 UTC) #10
mattm
ping
7 years ago (2013-11-26 01:17:22 UTC) #11
Ryan Sleevi
https://codereview.chromium.org/53763003/diff/840001/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://codereview.chromium.org/53763003/diff/840001/chrome/browser/profiles/profile_io_data.cc#newcode233 chrome/browser/profiles/profile_io_data.cc:233: void DidGetTPMInfoForUserOnUIThread(const std::string& username_hash, This is somewhat hard to ...
7 years ago (2013-11-27 00:24:11 UTC) #12
mattm
https://codereview.chromium.org/53763003/diff/840001/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://codereview.chromium.org/53763003/diff/840001/chrome/browser/profiles/profile_io_data.cc#newcode233 chrome/browser/profiles/profile_io_data.cc:233: void DidGetTPMInfoForUserOnUIThread(const std::string& username_hash, On 2013/11/27 00:24:11, Ryan Sleevi ...
7 years ago (2013-11-27 04:12:22 UTC) #13
mattm
ping
7 years ago (2013-12-04 03:33:47 UTC) #14
Ryan Sleevi
Implementation LGTM, just a few nits and suggestions. https://codereview.chromium.org/53763003/diff/1080001/chrome/browser/net/nss_context.cc File chrome/browser/net/nss_context.cc (right): https://codereview.chromium.org/53763003/diff/1080001/chrome/browser/net/nss_context.cc#newcode12 chrome/browser/net/nss_context.cc:12: #if ...
7 years ago (2013-12-04 20:59:55 UTC) #15
mattm
https://codereview.chromium.org/53763003/diff/1080001/chrome/browser/net/nss_context.cc File chrome/browser/net/nss_context.cc (right): https://codereview.chromium.org/53763003/diff/1080001/chrome/browser/net/nss_context.cc#newcode12 chrome/browser/net/nss_context.cc:12: #if defined(OS_CHROMEOS) On 2013/12/04 20:59:55, Ryan Sleevi wrote: > ...
7 years ago (2013-12-04 22:09:28 UTC) #16
mattm
xiyuan: chrome/browser/ui/webui/chromeos mmenke: chrome/browser/profiles
7 years ago (2013-12-04 22:10:35 UTC) #17
xiyuan
chrome/browser/ui/webui/chromeos LGTM
7 years ago (2013-12-04 22:12:11 UTC) #18
mmenke
On 2013/12/04 22:12:11, xiyuan wrote: > chrome/browser/ui/webui/chromeos LGTM I'll take a look tomorrow.
7 years ago (2013-12-04 22:23:08 UTC) #19
mmenke
profiles LGTM, deferring to rsleevi for correctness. https://codereview.chromium.org/53763003/diff/1140001/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://codereview.chromium.org/53763003/diff/1140001/chrome/browser/profiles/profile_io_data.cc#newcode325 chrome/browser/profiles/profile_io_data.cc:325: // or ...
7 years ago (2013-12-05 17:24:16 UTC) #20
mattm
https://codereview.chromium.org/53763003/diff/1140001/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://codereview.chromium.org/53763003/diff/1140001/chrome/browser/profiles/profile_io_data.cc#newcode325 chrome/browser/profiles/profile_io_data.cc:325: // or in the progress of being initialized. In ...
7 years ago (2013-12-05 21:30:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/53763003/1160001
7 years ago (2013-12-05 21:32:24 UTC) #22
mattm
rsleevi: Had to make some fixes for ScopedTestNSSDB use in CertificateManagerBrowserTest, want to take another ...
7 years ago (2013-12-05 23:03:34 UTC) #23
mattm
Adding Wan-Teh to check patchset 17 changes since Ryan is ooo.
7 years ago (2013-12-06 02:07:07 UTC) #24
Ryan Sleevi
lgtm
7 years ago (2013-12-06 08:43:54 UTC) #25
mattm
7 years ago (2013-12-06 22:24:11 UTC) #26
Message was sent while issue was closed.
Committed patchset #17 manually as r239266.

Powered by Google App Engine
This is Rietveld 408576698