Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 537603002: Revert of [fsp] Enable the File System Provider API for extensions. (Closed)

Created:
6 years, 3 months ago by Andre
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [fsp] Enable the File System Provider API for extensions. (patchset #2 id:20001 of https://codereview.chromium.org/527663002/) Reason for revert: Speculative revert, failed ChromiumOS browser_tests. [1422/1422] FileSystemProviderApiTest.Extension (11555 ms) 1 test failed: FileSystemProviderApiTest.Extension http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/11812 Original issue's description: > [fsp] Enable the File System Provider API for extensions. > > Previously, only apps were allowed to use this api, however most clients will > be actually written as extensions. > > TEST=browser_tests: *FileSystemProvider*Extension* > BUG=409487 > > Committed: https://chromium.googlesource.com/chromium/src/+/4acb869459901c6fa627473bb15b8a0f6190cc11 TBR=benwells@chromium.org,kalman@chromium.org,mtomasz@chromium.org NOTREECHECKS=true NOTRY=true BUG=409487 Committed: https://crrev.com/be173095fb2c38f914422473535df9b2da136bb2 Cr-Commit-Position: refs/heads/master@{#293148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -44 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/extensions/fileSystemProvider.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/file_system_provider/extension/manifest.json View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_system_provider/extension/test.js View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andre
Created Revert of [fsp] Enable the File System Provider API for extensions.
6 years, 3 months ago (2014-09-03 16:19:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/537603002/1
6 years, 3 months ago (2014-09-03 16:20:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as e3fe8de2f7a2ba064f05d0942d185fd12bcfa8a9
6 years, 3 months ago (2014-09-03 16:31:01 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be173095fb2c38f914422473535df9b2da136bb2
Cr-Commit-Position: refs/heads/master@{#293148}

Powered by Google App Engine
This is Rietveld 408576698