Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 537553002: Make 'Bookmark all tabs' window able to minimize upto default size. (Closed)

Created:
6 years, 3 months ago by siba.samal
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make 'Bookmark all tabs' window able to minimize upto default size. Currently 'Bookmark all tabs' and 'Bookmark Edit' window have different minimum and default sizes. Make them consistent. XIB Changes: BookmarkAllTabs & Bookmark Editor window's minimum and default sizes are set in .xib file located at chrome/app/nibs/BookmarkAllTabs.xib chrome/app/nibs/BookmarkEditor.xib Their window's default and minimum width and height values are decided by NSWindowRect & NSWindowContentMinSize key strings repectively. Set the correct values such that BookmarkAllTabs & Bookmark Editor windows are consistent BUG=401491 R=asvitkine@chromium.org TEST= 1) Launch chrome, open 2-3 tabs, right click on last tab and select 'Bookmark all tabs'. 2) On opened window increase the size by dragging towards R.H.S, and then try to decrease the size by dragging towards L.H.S and Observe. 3) The bookmark window should be minimize upto default size as of "Bookmark Edit" window. Committed: https://crrev.com/bbb307db411766f01264961152f136f025a5a624 Cr-Commit-Position: refs/heads/master@{#294338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/nibs/BookmarkAllTabs.xib View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
siba.samal
PTAL.
6 years, 3 months ago (2014-09-03 11:39:48 UTC) #1
siba.samal
On 2014/09/03 11:39:48, siba.samal wrote: > PTAL. @asvitkine PTAL.
6 years, 3 months ago (2014-09-09 05:41:21 UTC) #2
Alexei Svitkine (slow)
LGTM, I patched your CL in and it works as expected. Thanks! Per convention, please ...
6 years, 3 months ago (2014-09-10 20:23:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/537553002/1
6 years, 3 months ago (2014-09-11 04:25:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 85ca209014fa611de147928abc0f7abd78438acd
6 years, 3 months ago (2014-09-11 06:23:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 06:27:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbb307db411766f01264961152f136f025a5a624
Cr-Commit-Position: refs/heads/master@{#294338}

Powered by Google App Engine
This is Rietveld 408576698