Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 537543003: Add a get_random_bytes() syscall to replace the SRPC-based implementation (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Add a get_random_bytes() syscall to replace the SRPC-based implementation This will let us remove one remaining use of SRPC. This allows us to simplify tests/random/, since it no longer needs to link in a copy of libsrpc. Note that this doesn't remove "SecureRandom" from the name service or remove nacl_desc_rng.c. I'll do that in a follow-on change in order to keep this change smaller and easier to review. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST= run_random_test run_random_test_irt Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=13696

Patch Set 1 #

Patch Set 2 : Fix Gyp/GN #

Patch Set 3 : Fix glibc tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -43 lines) Patch
M src/shared/platform/nacl_global_secure_random.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/shared/platform/nacl_global_secure_random.c View 1 chunk +6 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/build.scons View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/include/bits/nacl_syscalls.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/trusted/service_runtime/nacl_syscall_handlers_gen.py View 2 chunks +3 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/service_runtime/sys_random.h View 1 chunk +22 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/sys_random.c View 1 chunk +50 lines, -0 lines 0 comments Download
M src/untrusted/irt/irt_random.c View 1 chunk +5 lines, -30 lines 0 comments Download
M src/untrusted/nacl/syscall_bindings_trampoline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/random/nacl.scons View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M tests/random/random_test.c View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Seaborn
6 years, 3 months ago (2014-09-03 22:29:10 UTC) #2
Roland McGrath
lgtm
6 years, 3 months ago (2014-09-04 17:33:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/mseaborn@chromium.org/537543003/40001
6 years, 3 months ago (2014-09-04 17:38:19 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 18:20:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 13696

Powered by Google App Engine
This is Rietveld 408576698