pkg/polymer_expressions/lib/eval.dart - Issue 53743002: introduce ObservableList.listChanges to keep list changes separate from property changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer_expressions/lib/eval.dart

Issue 53743002: introduce ObservableList.listChanges to keep list changes separate from property changes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer_expressions/lib/eval.dart

diff --git a/pkg/polymer_expressions/lib/eval.dart b/pkg/polymer_expressions/lib/eval.dart

index c12d4d12a5d45c352dd5d8807876a28c705601b3..b774807d05d0665b57a0b69f230a5cce5e5b2a49 100644

--- a/pkg/polymer_expressions/lib/eval.dart

+++ b/pkg/polymer_expressions/lib/eval.dart

@@ -589,12 +589,7 @@ class InObserver extends ExpressionObserver<InExpression>

}

if (iterable is ObservableList) {

- _subscription = (iterable as ObservableList).changes.listen(

- (List<ChangeRecord> changes) {

- if (changes.any((c) => c is ListChangeRecord)) {

- _invalidate(scope);

- }

- });

+ _subscription = iterable.listChanges.listen((_) => _invalidate(scope));

}

// TODO: make Comprehension observable and update it

« no previous file with comments | « pkg/polymer/lib/src/instance.dart ('k') | pkg/template_binding/lib/src/list_diff.dart » ('j') | no next file with comments »