Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 537413002: Bisect config params should alway be empty. (Closed)

Created:
6 years, 3 months ago by prasadv
Modified:
6 years, 3 months ago
Reviewers:
sullivan, qyearsley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Bisect config params should alway be empty. BUG= NOTRY=true Committed: https://crrev.com/6017d60fc4bfdf6ffb56f66aff105d23cb53b992 Cr-Commit-Position: refs/heads/master@{#293307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M tools/auto_bisect/bisect.cfg View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
prasadv
6 years, 3 months ago (2014-09-04 16:20:48 UTC) #2
sullivan
lgtm
6 years, 3 months ago (2014-09-04 16:21:37 UTC) #4
qyearsley
On 2014/09/04 16:21:37, sullivan wrote: > lgtm lgtm
6 years, 3 months ago (2014-09-04 16:22:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/537413002/1
6 years, 3 months ago (2014-09-04 16:22:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 454c8155d781b8901fec9cd6f2503f03ed4c4bce
6 years, 3 months ago (2014-09-04 16:24:49 UTC) #9
tonyg
Didn't we have a PRESUBMIT that verified this at one point in time?
6 years, 3 months ago (2014-09-04 16:27:57 UTC) #10
qyearsley
On 2014/09/04 16:27:57, tonyg wrote: > Didn't we have a PRESUBMIT that verified this at ...
6 years, 3 months ago (2014-09-04 16:30:09 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6017d60fc4bfdf6ffb56f66aff105d23cb53b992
Cr-Commit-Position: refs/heads/master@{#293307}

Powered by Google App Engine
This is Rietveld 408576698