Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 537403003: Added new histogram for analyzing SDCH corruption detection cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated last set of comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index d6b35dc59e5161552bf903ea967de966f3f45078..3c777a3b9a7371aa2bbcdf713237aa281678ea07 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -64,7 +64,7 @@ class URLRequestHttpJob::HttpFilterContext : public FilterContext {
virtual base::Time GetRequestTime() const OVERRIDE;
virtual bool IsCachedContent() const OVERRIDE;
virtual bool IsDownload() const OVERRIDE;
- virtual bool IsSdchResponse() const OVERRIDE;
+ virtual bool SdchResponseExpected() const OVERRIDE;
virtual int64 GetByteReadCount() const OVERRIDE;
virtual int GetResponseCode() const OVERRIDE;
virtual const URLRequestContext* GetURLRequestContext() const OVERRIDE;
@@ -124,7 +124,7 @@ void URLRequestHttpJob::HttpFilterContext::ResetSdchResponseToFalse() {
job_->sdch_dictionary_advertised_ = false;
}
-bool URLRequestHttpJob::HttpFilterContext::IsSdchResponse() const {
+bool URLRequestHttpJob::HttpFilterContext::SdchResponseExpected() const {
return job_->sdch_dictionary_advertised_;
}
@@ -1024,7 +1024,7 @@ Filter* URLRequestHttpJob::SetupFilter() const {
encoding_types.push_back(Filter::ConvertEncodingToType(encoding_type));
}
- if (filter_context_->IsSdchResponse()) {
+ if (filter_context_->SdchResponseExpected()) {
// We are wary of proxies that discard or damage SDCH encoding. If a server
// explicitly states that this is not SDCH content, then we can correct our
// assumption that this is an SDCH response, and avoid the need to recover

Powered by Google App Engine
This is Rietveld 408576698