Added new histogram for analyzing SDCH corruption detection cases.

net/base/sdch_manager.h

Index: net/base/sdch_manager.h
diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h
index 85633f58488286c9d0da92374f5c9006849ecdc7..ab888ca7c9dbb82cc25ba10a3f96c6beac474f35 100644
--- a/net/base/sdch_manager.h
+++ b/net/base/sdch_manager.h
@@ -127,7 +127,7 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
     META_REFRESH_RECOVERY = 70,            // Dictionary not found.
     // defunct =  71, // Almost the same as META_REFRESH_UNSUPPORTED.
     // defunct = 72,  // Almost the same as CACHED_META_REFRESH_UNSUPPORTED.
-    // defunct = 73,  // PASSING_THROUGH_NON_SDCH plus DISCARD_TENTATIVE_SDCH.
+    // defunct = 73,  // PASSING_THROUGH_NON_SDCH plus defunct 81.

[mmenke, 2014/09/08 19:27:27]

Not sure this comment change really makes things a whole lot clearer.

[Randy Smith (Not in Mondays), 2014/09/08 20:10:11]

It's a dangling reference without some change.  I've tweaked it to point at the
other enum (though that's a comment pointer layering violation; if you care
about that, I can clean it up).

     META_REFRESH_UNSUPPORTED = 74,         // Unrecoverable error.
     CACHED_META_REFRESH_UNSUPPORTED = 75,  // As above, but pulled from cache.
     PASSING_THROUGH_NON_SDCH = 76,  // Tagged sdch but missing dictionary-hash.
@@ -140,7 +140,7 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
 
     // Common decoded recovery methods.
     META_REFRESH_CACHED_RECOVERY = 80,  // Probably startup tab loading.
-    DISCARD_TENTATIVE_SDCH = 81,        // Server decided not to use sdch.
+    // defunct = 81, // Now tracked by ResponseCorruptionDetectionCause histo.
 
     // Non SDCH problems, only accounted for to make stat counting complete
     // (i.e., be able to be sure all dictionary advertisements are accounted