Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: net/filter/sdch_filter.h

Issue 537403003: Added new histogram for analyzing SDCH corruption detection cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/filter/sdch_filter.cc » ('j') | net/filter/sdch_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/filter/sdch_filter.h
diff --git a/net/filter/sdch_filter.h b/net/filter/sdch_filter.h
index 3cea340a9b26d737ab8442ada5e836fced5e2f97..c35ff8db87db6b9b01e1021fb0fb8887d0dadf40 100644
--- a/net/filter/sdch_filter.h
+++ b/net/filter/sdch_filter.h
@@ -54,6 +54,20 @@ class NET_EXPORT_PRIVATE SdchFilter : public Filter {
PASS_THROUGH, // Non-sdch content being passed without alteration.
};
+ // Disambiguate various sources for triggering a meta-refresh or failure.
+ enum CorruptionDetectionCause {
mmenke 2014/09/05 14:52:27 This stuff doesn't need to be in the header. Can
Randy Smith (Not in Mondays) 2014/09/07 01:14:16 Done.
+ RESPONSE_200,
+ RESPONSE_200_CACHED,
+ TENTATIVE_SDCH,
+ TENTATIVE_SDCH_CACHED,
+ DICTIONARY_NOT_FOUND,
+ DICTIONARY_NOT_FOUND_CACHED,
+ NON_SDCH_RESPONSE,
+ NON_SDCH_RESPONSE_CACHED,
+
+ META_REFRESH_CAUSE_MAX,
+ };
+
// Only to be instantiated by Filter::Factory.
explicit SdchFilter(const FilterContext& filter_context);
friend class Filter;
@@ -65,6 +79,10 @@ class NET_EXPORT_PRIVATE SdchFilter : public Filter {
// specified dest_buffer.
int OutputBufferExcess(char* const dest_buffer, size_t available_space);
+ // Record the particular reason we are falling into the meta-refresh
+ // pathway.
+ void RecordCorruptionDetectionCause(CorruptionDetectionCause cause);
+
// Context data from the owner of this filter.
const FilterContext& filter_context_;
« no previous file with comments | « no previous file | net/filter/sdch_filter.cc » ('j') | net/filter/sdch_filter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698