Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 537403002: bindings: Renames from/toInternalPointer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/dictionary_v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 455841b0ce7d17a873a105f6eabac38b8a2e50aa..1969f6b72c980d1367830e47555121762a2ea6a8 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -20,7 +20,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info
{# impl #}
{% if attribute.cached_attribute_validation_method %}
v8::Handle<v8::String> propertyName = v8AtomicString(info.GetIsolate(), "{{attribute.name}}");
- {{cpp_class}}* impl = {{v8_class}}::toNative(holder);
+ {{cpp_class}}* impl = {{v8_class}}::toImpl(holder);
if (!impl->{{attribute.cached_attribute_validation_method}}()) {
v8::Handle<v8::Value> v8Value = V8HiddenValue::getHiddenValue(info.GetIsolate(), holder, propertyName);
if (!v8Value.IsEmpty()) {
@@ -29,7 +29,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info
}
}
{% elif not attribute.is_static %}
- {{cpp_class}}* impl = {{v8_class}}::toNative(holder);
+ {{cpp_class}}* impl = {{v8_class}}::toImpl(holder);
{% endif %}
{% if interface_name == 'Window' and attribute.idl_type == 'EventHandler' %}
if (!impl->document())
@@ -225,12 +225,12 @@ v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
{% endif %}
{# impl #}
{% if attribute.put_forwards %}
- {{cpp_class}}* proxyImpl = {{v8_class}}::toNative(holder);
+ {{cpp_class}}* proxyImpl = {{v8_class}}::toImpl(holder);
{{attribute.cpp_type}} impl = WTF::getPtr(proxyImpl->{{attribute.name}}());
if (!impl)
return;
{% elif not attribute.is_static %}
- {{cpp_class}}* impl = {{v8_class}}::toNative(holder);
+ {{cpp_class}}* impl = {{v8_class}}::toImpl(holder);
{% endif %}
{% if attribute.idl_type == 'EventHandler' and interface_name == 'Window' %}
if (!impl->document())
@@ -314,7 +314,7 @@ v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI
if (contextData && contextData->activityLogger()) {
{% endif %}
{% if attribute.activity_logging_include_old_value_for_setter %}
- {{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder());
+ {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
{% if attribute.cpp_value_original %}
{{attribute.cpp_type}} {{attribute.cpp_value}}({{attribute.cpp_value_original}});
{% endif %}
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/dictionary_v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698