Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/bindings/core/v8/custom/V8ElementCustom.cpp

Issue 537403002: bindings: Renames from/toInternalPointer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('k') | Source/bindings/core/v8/custom/V8EventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8ElementCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8ElementCustom.cpp b/Source/bindings/core/v8/custom/V8ElementCustom.cpp
index 6546731c18414dbb01b015d69708a96db2d59e24..df7c1979d240efd205b75585b358af28d454f93e 100644
--- a/Source/bindings/core/v8/custom/V8ElementCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8ElementCustom.cpp
@@ -48,7 +48,7 @@ namespace blink {
void V8Element::scrollLeftAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
{
ExceptionState exceptionState(ExceptionState::SetterContext, "scrollLeft", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toNative(info.Holder());
+ Element* impl = V8Element::toImpl(info.Holder());
if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) {
TONATIVE_VOID(Dictionary, scrollOptionsHorizontal, Dictionary(value, info.GetIsolate()));
@@ -64,7 +64,7 @@ void V8Element::scrollLeftAttributeSetterCustom(v8::Local<v8::Value> value, cons
void V8Element::scrollTopAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
{
ExceptionState exceptionState(ExceptionState::SetterContext, "scrollTop", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toNative(info.Holder());
+ Element* impl = V8Element::toImpl(info.Holder());
if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) {
TONATIVE_VOID(Dictionary, scrollOptionsVertical, Dictionary(value, info.GetIsolate()));
@@ -85,8 +85,8 @@ void V8Element::scrollTopAttributeSetterCustom(v8::Local<v8::Value> value, const
// AnimationPlayer animate(AnimationEffect? effect);
void animate1Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- Element* impl = V8Element::toNative(info.Holder());
- TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
+ Element* impl = V8Element::toImpl(info.Holder());
+ TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toImplWithTypeCheck(info.GetIsolate(), info[0]));
v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effect)), impl);
}
@@ -94,8 +94,8 @@ void animate1Method(const v8::FunctionCallbackInfo<v8::Value>& info)
void animate2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "animate", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toNative(info.Holder());
- TONATIVE_VOID(Vector<Dictionary>, keyframes, toNativeArray<Dictionary>(info[0], 1, info.GetIsolate()));
+ Element* impl = V8Element::toImpl(info.Holder());
+ TONATIVE_VOID(Vector<Dictionary>, keyframes, toImplArray<Dictionary>(info[0], 1, info.GetIsolate()));
RefPtrWillBeRawPtr<AnimationPlayer> result = ElementAnimation::animate(*impl, keyframes, exceptionState);
if (exceptionState.throwIfNeeded())
return;
@@ -105,8 +105,8 @@ void animate2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
// AnimationPlayer animate(AnimationEffect? effect, double timing);
void animate3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- Element* impl = V8Element::toNative(info.Holder());
- TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
+ Element* impl = V8Element::toImpl(info.Holder());
+ TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toImplWithTypeCheck(info.GetIsolate(), info[0]));
TONATIVE_VOID(double, duration, static_cast<double>(info[1]->NumberValue()));
v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effect, duration)), impl);
}
@@ -114,8 +114,8 @@ void animate3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
// AnimationPlayer animate(AnimationEffect? effect, Dictionary timing);
void animate4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- Element* impl = V8Element::toNative(info.Holder());
- TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
+ Element* impl = V8Element::toImpl(info.Holder());
+ TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toImplWithTypeCheck(info.GetIsolate(), info[0]));
TONATIVE_VOID(Dictionary, timingInput, Dictionary(info[1], info.GetIsolate()));
if (!timingInput.isUndefinedOrNull() && !timingInput.isObject()) {
V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("animate", "Element", "parameter 2 ('timingInput') is not an object."), info.GetIsolate());
@@ -128,8 +128,8 @@ void animate4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
void animate5Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "animate", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toNative(info.Holder());
- TONATIVE_VOID(Vector<Dictionary>, keyframes, toNativeArray<Dictionary>(info[0], 1, info.GetIsolate()));
+ Element* impl = V8Element::toImpl(info.Holder());
+ TONATIVE_VOID(Vector<Dictionary>, keyframes, toImplArray<Dictionary>(info[0], 1, info.GetIsolate()));
TONATIVE_VOID(double, duration, static_cast<double>(info[1]->NumberValue()));
RefPtrWillBeRawPtr<AnimationPlayer> result = ElementAnimation::animate(*impl, keyframes, duration, exceptionState);
if (exceptionState.throwIfNeeded())
@@ -141,8 +141,8 @@ void animate5Method(const v8::FunctionCallbackInfo<v8::Value>& info)
void animate6Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "animate", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toNative(info.Holder());
- TONATIVE_VOID(Vector<Dictionary>, keyframes, toNativeArray<Dictionary>(info[0], 1, info.GetIsolate()));
+ Element* impl = V8Element::toImpl(info.Holder());
+ TONATIVE_VOID(Vector<Dictionary>, keyframes, toImplArray<Dictionary>(info[0], 1, info.GetIsolate()));
TONATIVE_VOID(Dictionary, timingInput, Dictionary(info[1], info.GetIsolate()));
if (!timingInput.isUndefinedOrNull() && !timingInput.isObject()) {
exceptionState.throwTypeError("parameter 2 ('timingInput') is not an object.");
« no previous file with comments | « Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('k') | Source/bindings/core/v8/custom/V8EventCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698