Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/bindings/core/v8/V8BindingTest.cpp

Issue 537403002: bindings: Renames from/toInternalPointer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/V8DOMWrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8BindingTest.cpp
diff --git a/Source/bindings/core/v8/V8BindingTest.cpp b/Source/bindings/core/v8/V8BindingTest.cpp
index 37392cb4a5641a74c3e3e338d1e86b648e56aba5..8865e8cd8d8c123047b975ff777313304eb0f541 100644
--- a/Source/bindings/core/v8/V8BindingTest.cpp
+++ b/Source/bindings/core/v8/V8BindingTest.cpp
@@ -298,14 +298,14 @@ TEST_F(V8ValueTraitsTest, v8Value)
CHECK_TOV8VALUE("5678", handleValue);
}
-TEST_F(V8ValueTraitsTest, toNativeArray)
+TEST_F(V8ValueTraitsTest, toImplArray)
{
{
v8::Handle<v8::Array> v8StringArray = v8::Array::New(m_scope.isolate(), 2);
v8StringArray->Set(toV8Value(0), toV8Value("Hello, World!"));
v8StringArray->Set(toV8Value(1), toV8Value("Hi, Mom!"));
- Vector<String> stringVector = toNativeArray<String>(v8StringArray, 0, m_scope.isolate());
+ Vector<String> stringVector = toImplArray<String>(v8StringArray, 0, m_scope.isolate());
EXPECT_EQ(2U, stringVector.size());
EXPECT_EQ("Hello, World!", stringVector[0]);
EXPECT_EQ("Hi, Mom!", stringVector[1]);
@@ -316,7 +316,7 @@ TEST_F(V8ValueTraitsTest, toNativeArray)
v8UnsignedArray->Set(toV8Value(1), toV8Value(1729));
v8UnsignedArray->Set(toV8Value(2), toV8Value(31773));
- Vector<unsigned> unsignedVector = toNativeArray<unsigned>(v8UnsignedArray, 0, m_scope.isolate());
+ Vector<unsigned> unsignedVector = toImplArray<unsigned>(v8UnsignedArray, 0, m_scope.isolate());
EXPECT_EQ(3U, unsignedVector.size());
EXPECT_EQ(42U, unsignedVector[0]);
EXPECT_EQ(1729U, unsignedVector[1]);
@@ -328,11 +328,11 @@ TEST_F(V8ValueTraitsTest, toNativeArray)
v8::Handle<v8::Array> v8RealArray = v8::Array::New(m_scope.isolate(), 1);
v8RealArray->Set(toV8Value(0), toV8Value(doublePi));
- Vector<double> doubleVector = toNativeArray<double>(v8RealArray, 0, m_scope.isolate());
+ Vector<double> doubleVector = toImplArray<double>(v8RealArray, 0, m_scope.isolate());
EXPECT_EQ(1U, doubleVector.size());
EXPECT_EQ(doublePi, doubleVector[0]);
- Vector<float> floatVector = toNativeArray<float>(v8RealArray, 0, m_scope.isolate());
+ Vector<float> floatVector = toImplArray<float>(v8RealArray, 0, m_scope.isolate());
EXPECT_EQ(1U, floatVector.size());
EXPECT_EQ(floatPi, floatVector[0]);
}
@@ -342,14 +342,14 @@ TEST_F(V8ValueTraitsTest, toNativeArray)
v8Array->Set(toV8Value(1), toV8Value(65535));
v8Array->Set(toV8Value(2), toV8Value(0.125));
- Vector<v8::Handle<v8::Value> > v8HandleVector = toNativeArray<v8::Handle<v8::Value> >(v8Array, 0, m_scope.isolate());
+ Vector<v8::Handle<v8::Value> > v8HandleVector = toImplArray<v8::Handle<v8::Value> >(v8Array, 0, m_scope.isolate());
EXPECT_EQ(3U, v8HandleVector.size());
NonThrowableExceptionState exceptionState;
EXPECT_EQ("Vini, vidi, vici.", toScalarValueString(v8HandleVector[0], exceptionState));
EXPECT_EQ(65535U, toUInt32(v8HandleVector[1]));
EXPECT_EQ(0.125, toFloat(v8HandleVector[2]));
- Vector<ScriptValue> scriptValueVector = toNativeArray<ScriptValue>(v8Array, 0, m_scope.isolate());
+ Vector<ScriptValue> scriptValueVector = toImplArray<ScriptValue>(v8Array, 0, m_scope.isolate());
EXPECT_EQ(3U, scriptValueVector.size());
String reportOnZela;
EXPECT_TRUE(scriptValueVector[0].toString(reportOnZela));
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/V8DOMWrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698