Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: Source/bindings/core/v8/DictionaryHelperForBindings.h

Issue 537403002: bindings: Renames from/toInternalPointer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 23 matching lines...) Expand all
34 struct DictionaryHelperTraits { 34 struct DictionaryHelperTraits {
35 }; 35 };
36 36
37 template <template <typename> class PointerType, typename T> 37 template <template <typename> class PointerType, typename T>
38 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, Poin terType<T>& value) 38 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, Poin terType<T>& value)
39 { 39 {
40 v8::Local<v8::Value> v8Value; 40 v8::Local<v8::Value> v8Value;
41 if (!dictionary.get(key, v8Value)) 41 if (!dictionary.get(key, v8Value))
42 return false; 42 return false;
43 43
44 value = DictionaryHelperTraits<T>::type::toNativeWithTypeCheck(dictionary.is olate(), v8Value); 44 value = DictionaryHelperTraits<T>::type::toImplWithTypeCheck(dictionary.isol ate(), v8Value);
45 return true; 45 return true;
46 } 46 }
47 47
48 template <template <typename> class PointerType, typename T> 48 template <template <typename> class PointerType, typename T>
49 bool DictionaryHelper::convert(const Dictionary& dictionary, Dictionary::Convers ionContext& context, const String& key, PointerType<T>& value) 49 bool DictionaryHelper::convert(const Dictionary& dictionary, Dictionary::Convers ionContext& context, const String& key, PointerType<T>& value)
50 { 50 {
51 Dictionary::ConversionContextScope scope(context); 51 Dictionary::ConversionContextScope scope(context);
52 52
53 if (!DictionaryHelper::get(dictionary, key, value)) 53 if (!DictionaryHelper::get(dictionary, key, value))
54 return true; 54 return true;
55 55
56 if (value) 56 if (value)
57 return true; 57 return true;
58 58
59 v8::Local<v8::Value> v8Value; 59 v8::Local<v8::Value> v8Value;
60 dictionary.get(key, v8Value); 60 dictionary.get(key, v8Value);
61 if (context.isNullable() && blink::isUndefinedOrNull(v8Value)) 61 if (context.isNullable() && blink::isUndefinedOrNull(v8Value))
62 return true; 62 return true;
63 63
64 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type.")); 64 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type."));
65 return false; 65 return false;
66 } 66 }
67 67
68 } // namespace blink 68 } // namespace blink
69 69
70 #endif // DictionaryHelperForBindings_h 70 #endif // DictionaryHelperForBindings_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/Dictionary.cpp ('k') | Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698