Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 537393002: Adjust autofilled property for <search> input and <select> elements (Closed)

Created:
6 years, 3 months ago by ziran.sun
Modified:
6 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adjust autofilled property for <search> input and <select> elements Set value of autofilled property to false in the following cases: - Cancel search via cancel button in <search> element. - Delete autofilled selected <select> option. This patch also - Merged test case for editing text in autofilled textarea. R=tkent@chromium.org BUG=395627 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181589

Patch Set 1 #

Patch Set 2 : Add platform specific expectation file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -187 lines) Patch
M LayoutTests/fast/forms/autofilled.html View 1 chunk +118 lines, -111 lines 0 comments Download
M LayoutTests/fast/forms/autofilled-expected.txt View 1 chunk +33 lines, -2 lines 0 comments Download
D LayoutTests/fast/forms/textarea/edit-autofilled-text.html View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/fast/forms/textarea/edit-autofilled-text-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
A LayoutTests/platform/linux/fast/forms/autofilled-expected.txt View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/platform/win-xp/fast/forms/autofilled-expected.txt View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/platform/win/fast/forms/autofilled-expected.txt View 1 1 chunk +38 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ziran.sun
Resubmit the previously previewed patch at - https://codereview.chromium.org/471803003/ Resubmitted because locally tests on Android run ...
6 years, 3 months ago (2014-09-08 12:27:12 UTC) #1
tkent
lgtm
6 years, 3 months ago (2014-09-08 23:14:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/537393002/20001
6 years, 3 months ago (2014-09-08 23:15:53 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 00:17:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181589

Powered by Google App Engine
This is Rietveld 408576698