Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 537363003: disable flaky test (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
tfarina, mtklein, reed1
CC:
reviews_skia.org, RĂ©mi Piotaix
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : widen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/SkResourceCacheTest.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein
6 years, 3 months ago (2014-09-04 16:04:58 UTC) #2
tfarina
lgtm https://codereview.chromium.org/537363003/diff/1/tests/SkResourceCacheTest.cpp File tests/SkResourceCacheTest.cpp (right): https://codereview.chromium.org/537363003/diff/1/tests/SkResourceCacheTest.cpp#newcode89 tests/SkResourceCacheTest.cpp:89: #if 0 // skia:2912 OK
6 years, 3 months ago (2014-09-04 17:30:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/537363003/1
6 years, 3 months ago (2014-09-04 17:38:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/537363003/20001
6 years, 3 months ago (2014-09-04 17:44:10 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 17:51:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 26abcf10a4994a0bb13a074d79baa85cd8d67b2c

Powered by Google App Engine
This is Rietveld 408576698