Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 537363002: Skia roll 0c88d82:a17aac8 with fixed build exclusions. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
jvanverth1, mtklein, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Skia roll 0c88d82:a17aac8 with fixed build exclusions. Apparently it's fatal for GN to try to remove something that doesn't exist, but not for GYP... the GYP list is way out of date. SkTaskGroup{.cpp,.h} are not currently listed in utils.gypi, so there's no need to remove them. https://skia.googlesource.com/skia/+log/0c88d8233ba3a8baa9b4dd6ef515def6b3749980..a17aac8bd4c755c3a24befc7fd297969c0bb0861 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg Bots seem to be failing before and after this CL. NOTRY=true BUG= Committed: https://crrev.com/1bd9a310d493c5a8aab0c2d7d5bf62050cd06f1f Cr-Commit-Position: refs/heads/master@{#293318}

Patch Set 1 #

Patch Set 2 : and roll #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M skia/skia_library.gypi View 1 2 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mtklein
6 years, 3 months ago (2014-09-04 13:17:45 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-09-04 13:40:16 UTC) #3
reed1
6 years, 3 months ago (2014-09-04 13:40:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/537363002/40001
6 years, 3 months ago (2014-09-04 13:42:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/12887) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/5907)
6 years, 3 months ago (2014-09-04 15:47:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/537363002/40001
6 years, 3 months ago (2014-09-04 15:50:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/537363002/40001
6 years, 3 months ago (2014-09-04 17:27:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e7e76b772f9d358c1a36f6eadcfa22932b1e8cc9
6 years, 3 months ago (2014-09-04 17:49:19 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:06 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bd9a310d493c5a8aab0c2d7d5bf62050cd06f1f
Cr-Commit-Position: refs/heads/master@{#293318}

Powered by Google App Engine
This is Rietveld 408576698