Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 537283002: Autocomplete: Fix a typo that flipped the extension keyword provider check for enabling in incognit… (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Peter Kasting, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Autocomplete: Fix a typo that flipped the extension keyword provider check for enabling in incognito mode. This is deliberately kept small for easy merging. BUG=409705 Committed: https://crrev.com/18a711cf186caef70fb6a316ee6a851ad2f9e81a Cr-Commit-Position: refs/heads/master@{#293481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/autocomplete/keyword_extensions_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
Tests added in a separate CL: chrome/browser/search/hotword_service_unittest.cc
6 years, 3 months ago (2014-09-05 05:23:35 UTC) #2
Peter Kasting
On 2014/09/05 05:23:35, Lei Zhang wrote: > Tests added in a separate CL: chrome/browser/search/hotword_service_unittest.cc I ...
6 years, 3 months ago (2014-09-05 05:37:31 UTC) #3
Lei Zhang
On 2014/09/05 05:37:31, Peter Kasting wrote: > On 2014/09/05 05:23:35, Lei Zhang wrote: > > ...
6 years, 3 months ago (2014-09-05 06:01:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/537283002/1
6 years, 3 months ago (2014-09-05 06:48:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8da6f947a4d8a55c344fea46ff814851dea105ef
6 years, 3 months ago (2014-09-05 08:34:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18a711cf186caef70fb6a316ee6a851ad2f9e81a
Cr-Commit-Position: refs/heads/master@{#293481}

Powered by Google App Engine
This is Rietveld 408576698