Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 537183003: Remove Mali-400/604 devices from GPU rasterization whitelist. (Closed)

Created:
6 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
ajuma, chromium-reviews, piman+watch_chromium.org, no sievers, Vangelis Kokkevis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Mali-400/604 devices from GPU rasterization whitelist. GPU raster was observed to cause pixel corruption on the Galaxy Note 2 (GT-N7100, Mali-400 MP, ES 2.0). Remove it from the GPU raster whitelist, as well as the international Galaxy S3 (GT-I9300) which also uses Mali 400. Also expand the Nexus 10 blacklist to all Mali-T604 devices. NOTRY=true BUG=409970 Committed: https://crrev.com/43c7e128fe621143496be0c495b629830ed4659a Cr-Commit-Position: refs/heads/master@{#293244}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Version number and 604 blacklist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
aelias_OOO_until_Jul13
PTAL.
6 years, 3 months ago (2014-09-03 22:29:50 UTC) #2
ernstm
On 2014/09/03 22:29:50, aelias wrote: > PTAL. Could we blacklist all devices with Mali 400 ...
6 years, 3 months ago (2014-09-03 22:51:27 UTC) #3
Zhenyao Mo
LGTM https://codereview.chromium.org/537183003/diff/1/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/537183003/diff/1/gpu/config/software_rendering_list_json.cc#newcode21 gpu/config/software_rendering_list_json.cc:21: "version": "9.3", Please update the version.
6 years, 3 months ago (2014-09-03 22:51:50 UTC) #4
aelias_OOO_until_Jul13
> Could we blacklist all devices with Mali 400 somehow? And also the T604 (Nexus ...
6 years, 3 months ago (2014-09-04 00:12:19 UTC) #5
Zhenyao Mo
LGTM again
6 years, 3 months ago (2014-09-04 00:29:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/537183003/20001
6 years, 3 months ago (2014-09-04 00:49:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6cf3413f76858ab84b5930f9134a4d2b6879dbbf
6 years, 3 months ago (2014-09-04 00:53:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43c7e128fe621143496be0c495b629830ed4659a
Cr-Commit-Position: refs/heads/master@{#293244}

Powered by Google App Engine
This is Rietveld 408576698