Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 537113002: filter apps that should not be in athena home card. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

filter apps that should not be in athena home card. BUG=407777 R=oshima@chromium.org TEST=manually Committed: https://crrev.com/1466fb3f7eeb48a721510829230ca2255e05cb22 Cr-Commit-Position: refs/heads/master@{#293268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M athena/content/content_app_model_builder.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Jun Mukai
6 years, 3 months ago (2014-09-03 21:01:29 UTC) #1
oshima
lgtm The description should probably be "filter apps that should not be in athena home ...
6 years, 3 months ago (2014-09-03 21:55:57 UTC) #2
Jun Mukai
On 2014/09/03 21:55:57, oshima wrote: > lgtm > > The description should probably be > ...
6 years, 3 months ago (2014-09-03 22:04:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/537113002/1
6 years, 3 months ago (2014-09-03 23:23:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1911)
6 years, 3 months ago (2014-09-04 02:13:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/537113002/1
6 years, 3 months ago (2014-09-04 03:09:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1980)
6 years, 3 months ago (2014-09-04 03:53:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/537113002/1
6 years, 3 months ago (2014-09-04 05:31:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6dce15be649f36af91cbbbb9fa14cc11ca4f8814
6 years, 3 months ago (2014-09-04 05:57:26 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1466fb3f7eeb48a721510829230ca2255e05cb22
Cr-Commit-Position: refs/heads/master@{#293268}

Powered by Google App Engine
This is Rietveld 408576698