Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js

Issue 537103002: Spec compliant url.search/url.hash setters over empty values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Sync expected output Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js ('k') | LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 description('Test setting the search attribute of the URL in HTMLAnchorElement . '); 1 description('Test setting the search attribute of the URL in HTMLAnchorElement . ');
2 2
3 var a = document.createElement('a'); 3 var a = document.createElement('a');
4 4
5 debug("Set search without '?'"); 5 debug("Set search without '?'");
6 a.href = "https://www.mydomain.com/path/?key=value"; 6 a.href = "https://www.mydomain.com/path/?key=value";
7 a.search = "value=key"; 7 a.search = "value=key";
8 shouldBe("a.href", "'https://www.mydomain.com/path/?value=key'"); 8 shouldBe("a.href", "'https://www.mydomain.com/path/?value=key'");
9 9
10 // IE8 does not encode spaces in search string 10 // IE8 does not encode spaces in search string
(...skipping 20 matching lines...) Expand all
31 debug("Set search to a malformed URL"); 31 debug("Set search to a malformed URL");
32 a.href = "bad:/|/url"; 32 a.href = "bad:/|/url";
33 a.search = "?value=key"; 33 a.search = "?value=key";
34 shouldBe("a.href", "'bad:/|/url?value=key'"); 34 shouldBe("a.href", "'bad:/|/url?value=key'");
35 35
36 debug("Set search to null"); 36 debug("Set search to null");
37 a.href = "https://www.mydomain.com/path/?key=value"; 37 a.href = "https://www.mydomain.com/path/?key=value";
38 a.search = null; 38 a.search = null;
39 shouldBe("a.href", "'https://www.mydomain.com/path/?null'"); 39 shouldBe("a.href", "'https://www.mydomain.com/path/?null'");
40 40
41 // Firefox 3.5.2 Removes the '?', and it shouldn't, per 41 // Firefox 3.5.2 Removes the '?', and it should, per
42 // http://dev.w3.org/html5/spec/infrastructure.html#url-decomposition-idl-attrib utes . 42 // http://url.spec.whatwg.org/#dom-url-search
43 debug("Set search to empty string"); 43 debug("Set search to empty string");
44 a.href = "https://www.mydomain.com/path/?key=value"; 44 a.href = "https://www.mydomain.com/path/?key=value";
45 a.search = ""; 45 a.search = "";
46 shouldBe("a.href", "'https://www.mydomain.com/path/?'"); 46 shouldBe("a.href", "'https://www.mydomain.com/path/'");
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js ('k') | LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698