Spec compliant url.search/url.hash setters over empty values.

Source/core/dom/DOMURLUtils.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2012 Motorola Mobility Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 103 matching lines @@
         return;
     kurl.setPath(value);
     setURL(kurl);
 }
 
 void DOMURLUtils::setSearch(const String& value)
 {
     KURL kurl = url();
     if (!kurl.isValid())
         return;
-    kurl.setQuery(value);
+
+    if (value[0] == '?')

[arv (Not doing code reviews), 2014/09/03 22:08:36]

Do we need to handle length 0 before this test?

[sof, 2014/09/04 06:52:24]

No real need, [] returns 0 over out-of-bounds indices (cf. setHash().) Too
implicit?

+        kurl.setQuery(value.length() == 1 ? String() : value.substring(1));

[arv (Not doing code reviews), 2014/09/03 22:08:36]

I thought KURL::setQuery did this?

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[sof, 2014/09/04 06:52:24]

That handling strips the leading '?', but doesn't clear the query for "?" (as it
should per http://url.spec.whatwg.org/#dom-url-search )

+    else
+        kurl.setQuery(value.isEmpty() ? String() : value);
+
     setURL(kurl);
 }
 
 void DOMURLUtils::setHash(const String& value)
 {
     KURL kurl = url();
     if (kurl.isNull())
         return;
 
     if (value[0] == '#')
-        kurl.setFragmentIdentifier(value.substring(1));
+        kurl.setFragmentIdentifier(value.length() == 1 ? String() : value.substring(1));
     else
-        kurl.setFragmentIdentifier(value);
+        kurl.setFragmentIdentifier(value.isEmpty() ? String() : value);
 
     setURL(kurl);
 }
 
 } // namespace blink