Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 537083002: Disable FAVICON_TRACKING in addition to SESSION. (Closed)

Created:
6 years, 3 months ago by maxbogue
Modified:
6 years, 3 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable FAVICON_TRACKING in addition to SESSION. BUG=378035 Committed: https://crrev.com/b39fee2c60f092a57657817dce06f4311a066306 Cr-Commit-Position: refs/heads/master@{#293348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
maxbogue
Please review. I think I should try to get this merged into M38, if that's ...
6 years, 3 months ago (2014-09-03 22:25:50 UTC) #2
Nicolas Zea
LGTM, and yeah, this is probably worth a merge.
6 years, 3 months ago (2014-09-03 22:44:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maxbogue@chromium.org/537083002/1
6 years, 3 months ago (2014-09-04 17:50:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f69ffa2e1353d589b0708f0c5c6f367c04a741a8
6 years, 3 months ago (2014-09-04 21:57:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b39fee2c60f092a57657817dce06f4311a066306
Cr-Commit-Position: refs/heads/master@{#293348}

Powered by Google App Engine
This is Rietveld 408576698