Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Side by Side Diff: content/test/test_content_client.cc

Issue 537063002: Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one last time Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/test_content_client.h" 5 #include "content/test/test_content_client.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
11 #include "base/strings/string_piece.h" 11 #include "base/strings/string_piece.h"
12 #include "ui/base/ui_base_paths.h"
12 13
13 namespace content { 14 namespace content {
14 15
15 TestContentClient::TestContentClient() 16 TestContentClient::TestContentClient()
16 : data_pack_(ui::SCALE_FACTOR_100P) { 17 : data_pack_(ui::SCALE_FACTOR_100P) {
17 // content_shell.pak is not built on iOS as it is not required. 18 // content_shell.pak is not built on iOS as it is not required.
18 #if !defined(OS_IOS) 19 #if !defined(OS_IOS)
19 base::FilePath content_shell_pack_path; 20 base::FilePath content_shell_pack_path;
20 #if defined(OS_ANDROID) 21 #if defined(OS_ANDROID)
21 // on Android all pak files are inside the paks folder. 22 PathService::Get(ui::DIR_RESOURCE_PAKS_ANDROID, &content_shell_pack_path);
22 PathService::Get(base::DIR_ANDROID_APP_DATA, &content_shell_pack_path);
23 content_shell_pack_path = content_shell_pack_path.Append(
24 FILE_PATH_LITERAL("paks"));
25 #else 23 #else
26 PathService::Get(base::DIR_MODULE, &content_shell_pack_path); 24 PathService::Get(base::DIR_MODULE, &content_shell_pack_path);
27 #endif 25 #endif
28 content_shell_pack_path = content_shell_pack_path.Append( 26 content_shell_pack_path = content_shell_pack_path.Append(
29 FILE_PATH_LITERAL("content_shell.pak")); 27 FILE_PATH_LITERAL("content_shell.pak"));
30 data_pack_.LoadFromPath(content_shell_pack_path); 28 data_pack_.LoadFromPath(content_shell_pack_path);
31 #endif 29 #endif
32 } 30 }
33 31
34 TestContentClient::~TestContentClient() { 32 TestContentClient::~TestContentClient() {
35 } 33 }
36 34
37 std::string TestContentClient::GetUserAgent() const { 35 std::string TestContentClient::GetUserAgent() const {
38 return std::string("TestContentClient"); 36 return std::string("TestContentClient");
39 } 37 }
40 38
41 base::StringPiece TestContentClient::GetDataResource( 39 base::StringPiece TestContentClient::GetDataResource(
42 int resource_id, 40 int resource_id,
43 ui::ScaleFactor scale_factor) const { 41 ui::ScaleFactor scale_factor) const {
44 base::StringPiece resource; 42 base::StringPiece resource;
45 data_pack_.GetStringPiece(resource_id, &resource); 43 data_pack_.GetStringPiece(resource_id, &resource);
46 return resource; 44 return resource;
47 } 45 }
48 46
49 } // namespace content 47 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698