components/components_unittests.isolate - Issue 537063002: Eliminate silently letting errors pass on pak loading.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/components_unittests.isolate

Issue 537063002: Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one last time Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'conditions': [	5 'conditions': [

6 ['OS=="android"', {	6 ['OS=="android"', {

7 'variables': {	7 'variables': {

8 'files': [	8 'files': [

9 '<(PRODUCT_DIR)/chrome_100_percent.pak',	9 '<(PRODUCT_DIR)/chrome_100_percent.pak',

10 '<(PRODUCT_DIR)/content_resources.pak',	10 '<(PRODUCT_DIR)/content_resources.pak',

	11 '<(PRODUCT_DIR)/content_shell.pak',

11 '<(PRODUCT_DIR)/locales/en-US.pak',	12 '<(PRODUCT_DIR)/locales/en-US.pak',

12 '<(PRODUCT_DIR)/resources.pak',	13 '<(PRODUCT_DIR)/resources.pak',

13 'test/data/',	14 'test/data/',

14 ],	15 ],

15 },	16 },

16 }],	17 }],

17 ],	18 ],

18 'includes': [	19 'includes': [

19 '../third_party/icu/icu.isolate',	20 '../third_party/icu/icu.isolate',

20 ],	21 ],

21 }	22 }

OLD	NEW

« no previous file with comments | « no previous file | components/test/run_all_unittests.cc » ('j') | ui/base/ui_base_tests.gypi » ('J')