Eliminate silently letting errors pass on pak loading.

ui/base/resource/resource_bundle_ios.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/resource/resource_bundle.h"
 
 #import <QuartzCore/QuartzCore.h>
 #import <UIKit/UIKit.h>
 
 #include "base/basictypes.h"
@@ skipping 16 matching lines @@
   NSString *resource_path;
   if ([mac_locale length]) {
     resource_path = [base::mac::FrameworkBundle() pathForResource:name
                                                            ofType:@"pak"
                                                       inDirectory:@""
                                                   forLocalization:mac_locale];
   } else {
     resource_path = [base::mac::FrameworkBundle() pathForResource:name
                                                            ofType:@"pak"];
   }
+
   if (!resource_path) {
-    // Return just the name of the pak file.
-    return base::FilePath(base::SysNSStringToUTF8(name) + ".pak");
+    // Trying to load a resources file that doesn't exist is an error. Return
+    // just the name of the pack file so that further down the line it is easier
+    // to track down what happened.
+    std::string name_string = base::SysNSStringToUTF8(name);
+    std::string locale_string = base::SysNSStringToUTF8(mac_locale);
+    LOG(ERROR) << "Tried to get the file path of a non-existent pak file '"
+               << name_string << "' for locale '" << locale_string << "'";
+    return base::FilePath(name_string + ".pak");
   }
   return base::FilePath([resource_path fileSystemRepresentation]);
 }
 
 }  // namespace
 
 void ResourceBundle::LoadCommonResources() {
-  AddDataPackFromPath(GetResourcesPakFilePath(@"chrome", nil),
-                      ui::SCALE_FACTOR_NONE);
-
   if (IsScaleFactorSupported(SCALE_FACTOR_100P)) {
     AddDataPackFromPath(GetResourcesPakFilePath(@"chrome_100_percent", nil),
                         SCALE_FACTOR_100P);
   }
 
   if (IsScaleFactorSupported(SCALE_FACTOR_200P)) {
     AddDataPackFromPath(GetResourcesPakFilePath(@"chrome_200_percent", nil),
                         SCALE_FACTOR_200P);
   }
 }
@@ skipping 112 matching lines @@
 
   // Another thread raced the load and has already cached the image.
   if (images_.count(resource_id))
     return images_[resource_id];
 
   images_[resource_id] = image;
   return images_[resource_id];
 }
 
 }  // namespace ui