Implement ManifestManager to handle manifest in content/

content/browser/web_contents/web_contents_impl.h

Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 922829cfb74239d69953ad80bc5301ab5154648e..dbfb0688c7eeca76abff86b89dd4cb06a89bf318 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -53,6 +53,7 @@ class DownloadItem;
 class GeolocationDispatcherHost;
 class InterstitialPageImpl;
 class JavaScriptDialogManager;
+class ManifestManagerHost;
 class MidiDispatcherHost;
 class PowerSaveBlocker;
 class RenderViewHost;
@@ -329,6 +330,7 @@ class CONTENT_EXPORT WebContentsImpl
                     const blink::WebFindOptions& options) OVERRIDE;
   virtual void StopFinding(StopFindAction action) OVERRIDE;
   virtual void InsertCSS(const std::string& css) OVERRIDE;
+  virtual void GetManifest(const GetManifestCallback&) OVERRIDE;

[jochen (gone - plz use gerrit), 2014/09/10 08:02:43]

why does this have to be on WebContents?

[mlamouri (slow - plz ping), 2014/09/10 17:06:19]

|manifest_manager_hosts_| has to live in WebContentsImpl AFAICT and the
candidates consumer of this API (::GetManifest()) are all using WebContents so
it seemed natural. In addition, my understanding is that WebContents is some
kind of tab representation and we really expect consumers to try to get the
manifest of the top-level frame, trying to access the manifest of another frame
is not something we currently expect.

What would you recommend?

 #if defined(OS_ANDROID)
   virtual base::android::ScopedJavaLocalRef<jobject> GetJavaWebContents()
       OVERRIDE;
@@ -1197,6 +1199,8 @@ class CONTENT_EXPORT WebContentsImpl
   scoped_ptr<ScreenOrientationDispatcherHost>
       screen_orientation_dispatcher_host_;
 
+  scoped_ptr<ManifestManagerHost> manifest_manager_host_;
+
   // The accessibility mode for all frames. This is queried when each frame
   // is created, and broadcast to all frames when it changes.
   AccessibilityMode accessibility_mode_;