Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: ui/views/bubble/bubble_border.cc

Issue 53703002: Remove IDR_BUBBLE_SHADOW, use IDR_WINDOW_BUBBLE_SHADOW_BIG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove IDR_BUBBLE_SHADOW, use IDR_WINDOW_BUBBLE_SHADOW_BIG. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/bubble/bubble_border.h ('k') | ui/views/examples/bubble_example.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_border.cc
diff --git a/ui/views/bubble/bubble_border.cc b/ui/views/bubble/bubble_border.cc
index 6494c7b2f4039751ddad5a33b57e9d8058fb4f66..0ea505798f52dd16f497795b0aa3aaf349f43e0f 100644
--- a/ui/views/bubble/bubble_border.cc
+++ b/ui/views/bubble/bubble_border.cc
@@ -75,12 +75,6 @@ const int kStroke = 1;
// Bubble border and arrow image resource ids. They don't use the IMAGE_GRID
// macro because there is no center image.
-const int kShadowImages[] = {
- IDR_BUBBLE_SHADOW_TL, IDR_BUBBLE_SHADOW_T, IDR_BUBBLE_SHADOW_TR,
- IDR_BUBBLE_SHADOW_L, 0, IDR_BUBBLE_SHADOW_R,
- IDR_BUBBLE_SHADOW_BL, IDR_BUBBLE_SHADOW_B, IDR_BUBBLE_SHADOW_BR };
-const int kShadowArrows[] = { 0, 0, 0, 0 };
-
const int kNoShadowImages[] = {
IDR_BUBBLE_TL, IDR_BUBBLE_T, IDR_BUBBLE_TR,
IDR_BUBBLE_L, 0, IDR_BUBBLE_R,
@@ -134,11 +128,6 @@ BorderImages* GetBorderImages(BubbleBorder::Shadow shadow) {
return set;
switch (shadow) {
- case BubbleBorder::SHADOW:
- // Note: SHADOW's border interior thickness is actually 10, but 0 is used
- // here to match the legacy appearance of SHADOW's extra large inset.
- set = new BorderImages(kShadowImages, kShadowArrows, 0, 0, 3);
- break;
case BubbleBorder::NO_SHADOW:
case BubbleBorder::NO_SHADOW_OPAQUE_BORDER:
set = new BorderImages(kNoShadowImages, kNoShadowArrows, 6, 7, 4);
@@ -380,10 +369,6 @@ void BubbleBackground::Paint(gfx::Canvas* canvas, views::View* view) const {
gfx::Rect bounds(view->GetLocalBounds());
bounds.Inset(border_->GetInsets());
- // Note: This matches the legacy appearance of SHADOW's extra large inset.
- if (border_->shadow() == BubbleBorder::SHADOW)
- bounds.Inset(-10, -10);
-
SkScalar radius = SkIntToScalar(border_->GetBorderCornerRadius());
path.addRoundRect(gfx::RectToSkRect(bounds), radius, radius);
canvas->DrawPath(path, paint);
« no previous file with comments | « ui/views/bubble/bubble_border.h ('k') | ui/views/examples/bubble_example.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698