Issue 537013002: Add outputs to GN's header checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 537013002: Add outputs to GN's header checker. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/9ac499fb49f22f4b5dba749325ab0b5eb21305c1 Cr-Commit-Position: refs/heads/master@{#293184}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -38 lines)			Patch
M	tools/gn/action_values.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/gn/action_values.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tools/gn/command_desc.cc	View	6 chunks	+69 lines, -17 lines	0 comments	Download
M	tools/gn/function_get_target_outputs.cc	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	tools/gn/header_checker.h	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	tools/gn/header_checker.cc	View	5 chunks	+49 lines, -9 lines	0 comments	Download

Total messages: 5 (1 generated)

brettw

Committed patchset #1 (id:1) to pending queue manually as d174349 (presubmit successful).

6 years, 3 months ago (2014-09-03 19:13:37 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:27:21 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9ac499fb49f22f4b5dba749325ab0b5eb21305c1
Cr-Commit-Position: refs/heads/master@{#293184}