NaCl: Update revision in DEPS, r13679 -> r13687

NaCl: Update revision in DEPS, r13679 -> r13687

This pulls in the following Native Client changes:

r13680: (bradnelson) Add back in android_tools, but in the right location.
r13682: (dyen) Added irt extension support for supplying the nacl_irt_memory interface.
r13683: (bradnelson) Disabling flaky test under asan.
r13684: (hans) service_runtime_x86_64.gyp: pass /nologo to ml64.exe
r13685: (mseaborn) Use uint32_t for untrusted pointer args: mmap() and munmap() syscalls
r13686: (jfb) LLVM 3.5 merge: add missing dependencies to PNaCl build
r13687: (dschuff) Build x86-32 IRT with PNaCl

R=mseaborn@chromium.org,bradnelson@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3910
TEST=browser_tests and nacl_integration

Committed: https://crrev.com/2b25dacae3b4b18ea229cf10b3fee1c68b602d4d
Cr-Commit-Position: refs/heads/master@{#293301}

[Derek Schuff, 2014-09-03 23:02:39]

Since we are just going to land an un-revert of 13687 with a change that doesn't
affect the chrome build at all, this DEPS roll should be perfectly fine.

[bradn, 2014-09-03 23:03:02]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2014-09-03 23:03:03]

lgtm

[Derek Schuff, 2014-09-03 23:23:04]

The CQ bit was checked by dschuff@chromium.org

[commit-bot: I haz the power, 2014-09-03 23:26:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dschuff@chromium.org/537003002/1

[Derek Schuff, 2014-09-04 00:15:23]

The CQ bit was unchecked by dschuff@chromium.org

[Derek Schuff, 2014-09-04 00:21:29]

The CQ bit was checked by dschuff@chromium.org

[commit-bot: I haz the power, 2014-09-04 00:24:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dschuff@chromium.org/537003002/1

[Derek Schuff, 2014-09-04 00:33:37]

The CQ bit was unchecked by dschuff@chromium.org

[Derek Schuff, 2014-09-04 00:42:11]

The CQ bit was checked by dschuff@chromium.org

[commit-bot: I haz the power, 2014-09-04 00:44:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dschuff@chromium.org/537003002/1

[commit-bot: I haz the power, 2014-09-04 02:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 02:29:39]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Mark Seaborn, 2014-09-04 14:46:57]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2014-09-04 14:47:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dschuff@chromium.org/537003002/1

[commit-bot: I haz the power, 2014-09-04 15:17:18]

Committed patchset #1 (id:1) as 708bfbfe22cbc2bcd24a996211cd9a41da96e96e

[Mark Seaborn, 2014-09-04 19:02:40]

Note that this rolled in:
r13687: (dschuff) Build x86-32 IRT with PNaCl
which was reverted in the NaCl repo, and you rolled it in *after* it was
reverted.

It would have been cleaner to roll in the re-commit of that change.  Rolling in
reverted changes might cause problems in general.

[Derek Schuff, 2014-09-04 19:31:41]

On 2014/09/04 19:02:40, Mark Seaborn wrote:
> Note that this rolled in:
> r13687: (dschuff) Build x86-32 IRT with PNaCl
> which was reverted in the NaCl repo, and you rolled it in *after* it was
> reverted.
> 
> It would have been cleaner to roll in the re-commit of that change.  Rolling
in
> reverted changes might cause problems in general.

Obviously it might cause problems in general. In this case the difference has no
effect on Chrome, as I mentioned in my first comment.

It looks like the change (unrelated to being reverted and re-landed in NaCl) may
have broken some SDK tests (
http://build.chromium.org/p/client.nacl.sdk/builders/mac-sdk-multi/builds/875...
) which I am currently trying to reproduce, so it may have to be reverted.

[Mark Seaborn, 2014-09-04 21:06:39]

On 4 September 2014 12:31, <dschuff@chromium.org> wrote:

> On 2014/09/04 19:02:40, Mark Seaborn wrote:
>
>> Note that this rolled in:
>> r13687: (dschuff) Build x86-32 IRT with PNaCl
>> which was reverted in the NaCl repo, and you rolled it in *after* it was
>> reverted.
>>
>
>  It would have been cleaner to roll in the re-commit of that change.
>> Rolling in
>
>  reverted changes might cause problems in general.
>>
>
> Obviously it might cause problems in general. In this case the difference
> has no
> effect on Chrome, as I mentioned in my first comment.
>

Ah, sorry, I didn't notice that comment.

Mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Derek Schuff, 2014-09-04 23:27:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/540163002/ by dschuff@chromium.org.

The reason for reverting is: This breaks NaCl SDK tests on mac (presumably
because that's the only one using the 32-bit IRT). See
https://code.google.com/p/nativeclient/issues/detail?id=3935.

[commit-bot: I haz the power, 2014-09-10 03:31:30]

Patchset 1 (id:??) landed as
https://crrev.com/2b25dacae3b4b18ea229cf10b3fee1c68b602d4d
Cr-Commit-Position: refs/heads/master@{#293301}