Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: src/lookup-inl.h

Issue 536943002: Never skip access checks when looking up properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LOOKUP_INL_H_ 5 #ifndef V8_LOOKUP_INL_H_
6 #define V8_LOOKUP_INL_H_ 6 #define V8_LOOKUP_INL_H_
7 7
8 #include "src/lookup.h" 8 #include "src/lookup.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 18 matching lines...) Expand all
29 29
30 return next; 30 return next;
31 } 31 }
32 32
33 33
34 LookupIterator::State LookupIterator::LookupInHolder(Map* map) { 34 LookupIterator::State LookupIterator::LookupInHolder(Map* map) {
35 STATIC_ASSERT(INTERCEPTOR == BEFORE_PROPERTY); 35 STATIC_ASSERT(INTERCEPTOR == BEFORE_PROPERTY);
36 DisallowHeapAllocation no_gc; 36 DisallowHeapAllocation no_gc;
37 switch (state_) { 37 switch (state_) {
38 case NOT_FOUND: 38 case NOT_FOUND:
39 if (map->IsJSProxyMap()) { 39 if (map->IsJSProxyMap()) return JSPROXY;
40 return JSPROXY; 40 if (map->is_access_check_needed()) return ACCESS_CHECK;
41 }
42 if (check_access_check() && map->is_access_check_needed()) {
43 return ACCESS_CHECK;
44 }
45 // Fall through. 41 // Fall through.
46 case ACCESS_CHECK: 42 case ACCESS_CHECK:
47 if (check_interceptor() && map->has_named_interceptor()) { 43 if (check_interceptor() && map->has_named_interceptor()) {
48 return INTERCEPTOR; 44 return INTERCEPTOR;
49 } 45 }
50 // Fall through. 46 // Fall through.
51 case INTERCEPTOR: 47 case INTERCEPTOR:
52 if (map->is_dictionary_map()) { 48 if (map->is_dictionary_map()) {
53 property_encoding_ = DICTIONARY; 49 property_encoding_ = DICTIONARY;
54 } else { 50 } else {
55 DescriptorArray* descriptors = map->instance_descriptors(); 51 DescriptorArray* descriptors = map->instance_descriptors();
56 number_ = descriptors->SearchWithCache(*name_, map); 52 number_ = descriptors->SearchWithCache(*name_, map);
57 if (number_ == DescriptorArray::kNotFound) return NOT_FOUND; 53 if (number_ == DescriptorArray::kNotFound) return NOT_FOUND;
58 property_encoding_ = DESCRIPTOR; 54 property_encoding_ = DESCRIPTOR;
59 } 55 }
60 return PROPERTY; 56 return PROPERTY;
61 case PROPERTY: 57 case PROPERTY:
62 return NOT_FOUND; 58 return NOT_FOUND;
63 case JSPROXY: 59 case JSPROXY:
64 case TRANSITION: 60 case TRANSITION:
65 UNREACHABLE(); 61 UNREACHABLE();
66 } 62 }
67 UNREACHABLE(); 63 UNREACHABLE();
68 return state_; 64 return state_;
69 } 65 }
70 } 66 }
71 } // namespace v8::internal 67 } // namespace v8::internal
72 68
73 #endif // V8_LOOKUP_INL_H_ 69 #endif // V8_LOOKUP_INL_H_
OLDNEW
« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698