Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 536923002: ARM64: Use templates for simulated memory accesses. (Closed)

Created:
6 years, 3 months ago by jbramley
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ARM64: Use templates for simulated memory accesses. This cleans up the memory interface somewhat, and also avoids a memcpy call that the compiler can't optimise away. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23640

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -149 lines) Patch
M src/arm64/simulator-arm64.h View 3 chunks +24 lines, -16 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 6 chunks +47 lines, -133 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
jbramley
https://codereview.chromium.org/536923002/diff/1/src/arm64/simulator-arm64.cc File src/arm64/simulator-arm64.cc (right): https://codereview.chromium.org/536923002/diff/1/src/arm64/simulator-arm64.cc#newcode1503 src/arm64/simulator-arm64.cc:1503: case STR_d: MemoryWrite<double>(address, dreg(srcdst)); break; `git cl format` doesn't ...
6 years, 3 months ago (2014-09-03 10:51:26 UTC) #2
jbramley
6 years, 3 months ago (2014-09-03 10:52:08 UTC) #4
Benedikt Meurer
I think it's OK for this case. LGTM
6 years, 3 months ago (2014-09-03 10:52:38 UTC) #5
jbramley
6 years, 3 months ago (2014-09-03 11:11:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as 23640 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698