Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 536903002: AX: Make the calendar role "grid". (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dmazzoni
Project:
blink
Visibility:
Public.

Description

AX: Make the calendar role "grid". Rows have role="row", and cells have role="girdcell". We apply aria-activedescendant to the calendar because the calendar cell is not focusable. Thus, each of cells needs to have id=. Also, cells should have descriptive text as aria-label. - getLocale() needs to replace _ with - because Intl.DateTimeFormat doesn't accept _. - This CL doesn't improve the calendar picker for type=month and type=week, and won't be harmful for them. BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181462

Patch Set 1 #

Total comments: 3

Patch Set 2 : /_/g and timezone-independecy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
A LayoutTests/fast/forms/calendar-picker/date-picker-ax.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/calendar-picker/date-picker-ax-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/resources/picker-common.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/resources/calendarPicker.js View 1 7 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Please review this. This CL still has a bug that we don't have a11y events ...
6 years, 3 months ago (2014-09-03 09:32:06 UTC) #2
keishi
LGTM https://codereview.chromium.org/536903002/diff/1/Source/web/resources/calendarPicker.js File Source/web/resources/calendarPicker.js (right): https://codereview.chromium.org/536903002/diff/1/Source/web/resources/calendarPicker.js#newcode78 Source/web/resources/calendarPicker.js:78: return (global.params.locale || "en-us").toLowerCase().replace(/_/, '-'); nit: I'm not ...
6 years, 3 months ago (2014-09-03 12:09:35 UTC) #3
tkent
https://codereview.chromium.org/536903002/diff/1/Source/web/resources/calendarPicker.js File Source/web/resources/calendarPicker.js (right): https://codereview.chromium.org/536903002/diff/1/Source/web/resources/calendarPicker.js#newcode78 Source/web/resources/calendarPicker.js:78: return (global.params.locale || "en-us").toLowerCase().replace(/_/, '-'); On 2014/09/03 12:09:35, keishi ...
6 years, 3 months ago (2014-09-05 04:54:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/536903002/40001
6 years, 3 months ago (2014-09-05 10:01:15 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 10:05:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 181462

Powered by Google App Engine
This is Rietveld 408576698