Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 536873002: [android_webview] Call super.onMeasure in AwTestContainerView. (Closed)

Created:
6 years, 3 months ago by mkosiba (inactive)
Modified:
6 years, 3 months ago
Reviewers:
boliu, no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Call super.onMeasure in AwTestContainerView. This essentially reverts http://crrev.com/531583002. The super call is necessary for measuring children, however the super call should also happen before the call th mAwContents.onMeasure to make sure the right set of measuredDimensions are used. BUG=None TEST=AndroidWebViewTest TBR=boliu@chromium.org Committed: https://crrev.com/0b147e5fa870b3cd3112499503a3877f76c38429 Cr-Commit-Position: refs/heads/master@{#293111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/536873002/1
6 years, 3 months ago (2014-09-03 08:51:51 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 09:47:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as fa7bb93ef5d23f25ec7c64b74dfd8a2cd9c616f9
6 years, 3 months ago (2014-09-03 10:17:02 UTC) #5
no sievers
On 2014/09/03 10:17:02, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 3 months ago (2014-09-03 17:20:04 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b147e5fa870b3cd3112499503a3877f76c38429
Cr-Commit-Position: refs/heads/master@{#293111}

Powered by Google App Engine
This is Rietveld 408576698