Issue 53683007: Have SelectorQuery API take rootNode by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53683007: Have SelectorQuery API take rootNode by reference (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
adamk

CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have SelectorQuery API take rootNode by reference Have SelectorQuery API take rootNode by reference instead of taking a pointer as it is expected to be non-null. This also gets rid of several unnecessary null checks. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161095

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -227 lines)			Patch
M	Source/core/css/ElementRuleCollector.cpp	View	3 chunks	+15 lines, -14 lines	0 comments	Download
M	Source/core/css/SelectorChecker.h	View	2 chunks	+13 lines, -13 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	19 chunks	+97 lines, -107 lines	0 comments	Download
M	Source/core/css/SelectorCheckerFastPath.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/SelectorCheckerFastPath.cpp	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.h	View	3 chunks	+17 lines, -17 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.cpp	View	13 chunks	+57 lines, -59 lines	0 comments	Download
M	Source/core/dom/StyleSheetScopingNodeList.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLFormControlElement.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLOptGroupElement.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/53683007/1

7 years, 1 month ago (2013-10-31 20:29:35 UTC) #3

Message was sent while issue was closed.

Change committed as 161095

Expand Messages | Collapse Messages