Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Issue 536823004: Move 'Versioning' topic from overview to download page. (Closed)

Created:
6 years, 3 months ago by jpmedley
Modified:
6 years, 3 months ago
Reviewers:
mkearney1, smain, JF
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move 'Versioning' topic from overview to download page. BUG=none R= mkearney@chromium.org, smain@chromium.org TEST=none NOTRY=true (documentation only change) Committed: https://crrev.com/666ae732a0617c25ea7f10660fc39cbfedfba80a Cr-Commit-Position: refs/heads/master@{#296075}

Patch Set 1 #

Patch Set 2 : Fixes so that CL will upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M native_client_sdk/doc_generated/overview.html View 1 2 chunks +11 lines, -21 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/download.html View 1 5 chunks +15 lines, -6 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 2 chunks +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/overview.rst View 1 1 chunk +0 lines, -17 lines 0 comments Download
M native_client_sdk/src/doc/sdk/download.rst View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
jpmedley
Please review.
6 years, 3 months ago (2014-09-05 21:27:03 UTC) #1
binji
Seems OK to me, but why are you moving it to the download page?
6 years, 3 months ago (2014-09-09 17:35:15 UTC) #3
jpmedley
On 2014/09/09 17:35:15, binji wrote: > Seems OK to me, but why are you moving ...
6 years, 3 months ago (2014-09-09 18:07:29 UTC) #4
jpmedley
On 2014/09/09 18:07:29, jmedley wrote: > On 2014/09/09 17:35:15, binji wrote: > > Seems OK ...
6 years, 3 months ago (2014-09-09 18:08:18 UTC) #5
jpmedley
I just noticed that this went to the wrong guy originally. The question to ask ...
6 years, 3 months ago (2014-09-22 21:58:46 UTC) #7
JF
lgtm
6 years, 3 months ago (2014-09-22 22:11:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/536823004/1
6 years, 3 months ago (2014-09-22 22:15:05 UTC) #10
commit-bot: I haz the power
Failed to apply patch for native_client_sdk/doc_generated/overview.html: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-22 22:18:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/536823004/20001
6 years, 3 months ago (2014-09-22 22:36:35 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bb9b28e1997dcd5e9631fb4564ad5e462b27b506
6 years, 3 months ago (2014-09-22 22:37:28 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:38:02 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/666ae732a0617c25ea7f10660fc39cbfedfba80a
Cr-Commit-Position: refs/heads/master@{#296075}

Powered by Google App Engine
This is Rietveld 408576698