Skip tracking status in map-branches when -v flag is not supplied.

Skip tracking status in map-branches when -v flag is not supplied.

This CL prevents map-branches from loading the tracking status when
the -v flag is not supplied. This prevents the vanilla map-branches
from taking a potentially long time to retrieve the tracking status.

BUG=410137
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291846

[calamity, 2014-09-03 03:16:35]

Patchset #1 (id:1) has been deleted

[calamity, 2014-09-03 03:17:41]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-09-03 03:21:56]

lgtm

https://codereview.chromium.org/536793002/diff/20001/git_common.py
File git_common.py (right):

https://codereview.chromium.org/536793002/diff/20001/git_common.py#newcode736
git_common.py:736: def get_all_tracking_info(include_tracking_status=True):
Don't set a default here. There isn't a "correct" good answer, so just leave it
out and force the caller to decide.

https://codereview.chromium.org/536793002/diff/20001/git_map_branches.py
File git_map_branches.py (right):

https://codereview.chromium.org/536793002/diff/20001/git_map_branches.py#newc...
git_map_branches.py:113: self.__gone_branches = set()
Make sure all the fields are initialized in the constructor:
self.__tracking_info = None
self.parent_map = collections.defaultdict(list) (move from start).
self.__current_branch = None
self.__current_hash = None
self.__tag_set = None

[calamity, 2014-09-03 04:38:52]

calamity@chromium.org changed reviewers:
+ iannucci@chromium.org

[calamity, 2014-09-03 04:38:53]

+ianucci@ for OWNERS.

https://codereview.chromium.org/536793002/diff/20001/git_common.py
File git_common.py (right):

https://codereview.chromium.org/536793002/diff/20001/git_common.py#newcode736
git_common.py:736: def get_all_tracking_info(include_tracking_status=True):
On 2014/09/03 03:21:55, Matt Giuca wrote:
> Don't set a default here. There isn't a "correct" good answer, so just leave
it
> out and force the caller to decide.

Done.

https://codereview.chromium.org/536793002/diff/20001/git_map_branches.py
File git_map_branches.py (right):

https://codereview.chromium.org/536793002/diff/20001/git_map_branches.py#newc...
git_map_branches.py:113: self.__gone_branches = set()
On 2014/09/03 03:21:55, Matt Giuca wrote:
> Make sure all the fields are initialized in the constructor:
> self.__tracking_info = None
> self.parent_map = collections.defaultdict(list) (move from start).
> self.__current_branch = None
> self.__current_hash = None
> self.__tag_set = None

Done.

[iannucci, 2014-09-03 15:51:12]

lgtm

https://codereview.chromium.org/536793002/diff/40001/git_common.py
File git_common.py (right):

https://codereview.chromium.org/536793002/diff/40001/git_common.py#newcode736
git_common.py:736: def get_all_tracking_info(include_tracking_status):
hm.. should rename this function?

get_all_tracking_info_but_sometimes_not(dont_do_all_of_it_but_some_of_it_instead)

:D

Maybe:

get_branches_info(include_ahead_behind)

[calamity, 2014-09-08 00:50:03]

Patchset #3 (id:60001) has been deleted

[calamity, 2014-09-08 00:53:51]

Patchset #3 (id:80001) has been deleted

[calamity, 2014-09-08 00:59:22]

Patchset #3 (id:100001) has been deleted

[calamity, 2014-09-08 01:00:29]

https://codereview.chromium.org/536793002/diff/40001/git_common.py
File git_common.py (right):

https://codereview.chromium.org/536793002/diff/40001/git_common.py#newcode736
git_common.py:736: def get_all_tracking_info(include_tracking_status):
On 2014/09/03 15:51:12, iannucci wrote:
> hm.. should rename this function?
> 
>
get_all_tracking_info_but_sometimes_not(dont_do_all_of_it_but_some_of_it_instead)
> 
> :D
> 
> Maybe:
> 
> get_branches_info(include_ahead_behind)

Done.

[calamity, 2014-09-08 01:00:35]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-09-08 01:01:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/536793002/120001

[commit-bot: I haz the power, 2014-09-08 01:03:22]

Committed patchset #3 (id:120001) as 291846