Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 536783003: Call ChildThread::Shutdown in PpapiThread::Shutdown. (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Call ChildThread::Shutdown in PpapiThread::Shutdown. BUG=None Committed: https://crrev.com/4ff79fa7b6477808bdff2bb7589da312269d8ec2 Cr-Commit-Position: refs/heads/master@{#293260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tzik
PTL. Other subclasses of ChildThread seem to call ChildThread::Shutdown, which is overridden by the subclass's ...
6 years, 3 months ago (2014-09-03 04:02:20 UTC) #2
piman
lgtm
6 years, 3 months ago (2014-09-03 20:14:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/536783003/1
6 years, 3 months ago (2014-09-03 21:21:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9825)
6 years, 3 months ago (2014-09-04 03:12:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/536783003/1
6 years, 3 months ago (2014-09-04 03:53:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2cee1f14bef85a8aeb25c7b75f0b71b203dc8252
6 years, 3 months ago (2014-09-04 04:59:28 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff79fa7b6477808bdff2bb7589da312269d8ec2
Cr-Commit-Position: refs/heads/master@{#293260}

Powered by Google App Engine
This is Rietveld 408576698