[Password Manager] Remove action match requirement for RemoveLogin() on Gnome

[Password Manager] Remove action match requirement for RemoveLogin() on Gnome

This requirement only exists on this implementation of PasswordStore.

BUG=408783
Committed: https://crrev.com/cce52da2a0ae0027da299d87d0b8d20685f48f56
Cr-Commit-Position: refs/heads/master@{#293179}

[Garrett Casto, 2014-09-03 06:57:56]

gcasto@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2014-09-03 09:51:07]

LGTM -- AddLoginSearch also does not consider action URLs, so there is actually
no way, AFAICT, to create two password entries which would only differ in the
action URL. So disregarding action URL when deleting will have no effect,
because if all other parameters are the same, action URLs must be as well.

[Garrett Casto, 2014-09-03 17:32:15]

On 2014/09/03 09:51:07, vabr (Chromium) wrote:
> LGTM -- AddLoginSearch also does not consider action URLs, so there is
actually
> no way, AFAICT, to create two password entries which would only differ in the
> action URL. So disregarding action URL when deleting will have no effect,
> because if all other parameters are the same, action URLs must be as well.

I realized that I forgot to put the full context of this describing why it's a
problem in the child bug instead of the meta-bug. I've updated it now. The
problem is that sometimes we update the action url for a currently saved
credential and then try to remove it, which fails. I agree with your assessment
that it's not possible to have two saved credentials that differ on by action
url.

[Garrett Casto, 2014-09-03 17:32:21]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-09-03 17:35:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gcasto@chromium.org/536783002/1

[commit-bot: I haz the power, 2014-09-03 18:52:27]

Committed patchset #1 (id:1) as 3a9cf166f5178e8d76b9efe8990c445f020832b5

[commit-bot: I haz the power, 2014-09-10 03:27:09]

Patchset 1 (id:??) landed as
https://crrev.com/cce52da2a0ae0027da299d87d0b8d20685f48f56
Cr-Commit-Position: refs/heads/master@{#293179}