Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 536753004: chromeos: power: Make RendererFreezer asynchronous (Closed)

Created:
6 years, 3 months ago by Chirantan Ekbote
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, davemoore+watch_chromium.org, dominicc (has gone to gerrit), nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

chromeos: power: Make RendererFreezer asynchronous In preparation for the upcoming integration with service workers, which need to do a lot of asynchronous work before the renderers are frozen, have the RendererFreezer grab a suspend readiness callback that it will run at some point in the future when it is ready to suspend. BUG=364339, 411046 Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>; Committed: https://crrev.com/d0f2d2367d60389c4b296d823b19bc34df8e769f Cr-Commit-Position: refs/heads/master@{#293426}

Patch Set 1 #

Patch Set 2 : Fix build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M chrome/browser/chromeos/power/renderer_freezer.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/power/renderer_freezer.cc View 1 3 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Chirantan Ekbote
Please take a look.
6 years, 3 months ago (2014-09-04 22:24:07 UTC) #2
Daniel Erat
lgtm (it'd be nice to have tests for this code, though)
6 years, 3 months ago (2014-09-04 22:38:45 UTC) #3
Chirantan Ekbote
Ok, I'll refactor and add tests in a separate CL.
6 years, 3 months ago (2014-09-05 00:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chirantan@chromium.org/536753004/20001
6 years, 3 months ago (2014-09-05 00:16:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7c157c765d047af9279a76054281ff1a0df6bb5b
6 years, 3 months ago (2014-09-05 03:51:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0f2d2367d60389c4b296d823b19bc34df8e769f
Cr-Commit-Position: refs/heads/master@{#293426}

Powered by Google App Engine
This is Rietveld 408576698