Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5563)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 536753003: Add recommended extension installation support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-3
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index bdaa3f96e4e69a601c04cefcea135ed3dc2035c8..106827da2f619c00e401aa590bf69e300cb7b6ff 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -37,6 +37,7 @@
* kioskOnly: boolean,
* locationText: string,
* managedInstall: boolean,
+ * recommendedInstall: boolean,
Finnur 2014/10/06 14:01:42 It is pretty clear this list should be alphabetica
binjin 2014/10/06 18:48:47 Done.
* manifestErrors: (Array.<RuntimeError>|undefined),
* name: string,
* offlineEnabled: boolean,
@@ -170,6 +171,8 @@ cr.define('options', function() {
extension.dependentExtensions.length > 0) {
node.classList.add('may-not-modify');
node.classList.add('may-not-remove');
+ } else if (extension.recommendedInstall) {
+ node.classList.add('may-not-remove');
} else if (extension.suspiciousInstall || extension.corruptInstall) {
node.classList.add('may-not-modify');
}
@@ -395,7 +398,7 @@ cr.define('options', function() {
}
// Then the 'managed, cannot uninstall/disable' message.
Finnur 2014/10/06 14:01:42 nit: This comment is out of date now, no?
binjin 2014/10/06 18:48:47 I think the comment looks fine to me. It's not res
- if (extension.managedInstall) {
+ if (extension.managedInstall || extension.recommendedInstall) {
node.querySelector('.managed-message').hidden = false;
} else {
if (extension.suspiciousInstall) {

Powered by Google App Engine
This is Rietveld 408576698