Add recommended extension installation support

chrome/browser/extensions/extension_management.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
@@ skipping 122 matching lines @@
 }
 
 void ExtensionManagement::RemoveObserver(Observer* observer) {
   observer_list_.RemoveObserver(observer);
 }
 
 ManagementPolicy::Provider* ExtensionManagement::GetProvider() {
   return provider_.get();
 }
 
-bool ExtensionManagement::BlacklistedByDefault() {
+bool ExtensionManagement::BlacklistedByDefault() const {
   return default_settings_.installation_mode == INSTALLATION_BLOCKED;
 }
 
 scoped_ptr<base::DictionaryValue> ExtensionManagement::GetForceInstallList()
     const {
-  scoped_ptr<base::DictionaryValue> forcelist(new base::DictionaryValue());
+  scoped_ptr<base::DictionaryValue> install_list(new base::DictionaryValue());
   for (SettingsIdMap::const_iterator it = settings_by_id_.begin();
        it != settings_by_id_.end();
        ++it) {
     if (it->second.installation_mode == INSTALLATION_FORCED) {
       ExternalPolicyLoader::AddExtension(
-          forcelist.get(), it->first, it->second.update_url);
+          install_list.get(), it->first, it->second.update_url);
     }
   }
-  return forcelist.Pass();
+  return install_list.Pass();
+}
+
+scoped_ptr<base::DictionaryValue>
+ExtensionManagement::GetRecommendedInstallList() const {
+  scoped_ptr<base::DictionaryValue> install_list(new base::DictionaryValue());
+  for (SettingsIdMap::const_iterator it = settings_by_id_.begin();
+       it != settings_by_id_.end();
+       ++it) {
+    if (it->second.installation_mode == INSTALLATION_RECOMMENDED) {
+      ExternalPolicyLoader::AddExtension(
+          install_list.get(), it->first, it->second.update_url);
+    }
+  }
+  return install_list.Pass();
 }
 
 bool ExtensionManagement::IsInstallationAllowed(const ExtensionId& id) const {
   return ReadById(id).installation_mode != INSTALLATION_BLOCKED;
 }
 
 bool ExtensionManagement::IsOffstoreInstallAllowed(const GURL& url,
                                                    const GURL& referrer_url) {
   // No allowed install sites specified, disallow by default.
   if (!global_settings_.has_restricted_install_sources)
@@ skipping 100 matching lines @@
     std::string update_url;
     for (base::DictionaryValue::Iterator it(*forced_list_pref); !it.IsAtEnd();
          it.Advance()) {
       if (!crx_file::id_util::IdIsValid(it.key()))
         continue;
       const base::DictionaryValue* dict_value = NULL;
       if (it.value().GetAsDictionary(&dict_value) &&
           dict_value->GetStringWithoutPathExpansion(
               ExternalProviderImpl::kExternalUpdateUrl, &update_url)) {
         IndividualSettings* by_id = AccessById(it.key());
-        by_id->installation_mode = INSTALLATION_FORCED;
+        by_id->installation_mode = INSTALLATION_RECOMMENDED;

[Joao da Silva, 2014/09/19 07:55:52]

Why? This is the force list, so should be FORCED here.

[binjin, 2014/09/19 09:25:28]

it's added by mistake, it's for manual testing.

[Joao da Silva, 2014/09/19 09:27:48]

Ok. Please remove it and send an updated CL when ready.

[binjin, 2014/09/19 10:09:56]

Done.

         by_id->update_url = update_url;
       }
     }
   }
 
   if (install_sources_pref) {
     global_settings_.has_restricted_install_sources = true;
     for (base::ListValue::const_iterator it = install_sources_pref->begin();
          it != install_sources_pref->end(); ++it) {
       std::string url_pattern;
@@ skipping 124 matching lines @@
 }
 
 void ExtensionManagementFactory::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* user_prefs) {
   user_prefs->RegisterDictionaryPref(
       pref_names::kExtensionManagement,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 }
 
 }  // namespace extensions